Collapse BaseRequestContext into RequestContext #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
collapse-request-context
branch
from
73e2080
to
ec3a10e
Compare
adam-fowler
force-pushed
the
collapse-request-context
branch
from
ec3a10e
to
9287729
Compare
Joannis
approved these changes
Jun 15, 2024
adam-fowler
added a commit
that referenced
this pull request
Jun 15, 2024
…469) * Replace RequestContext initialization parameters with associatedtype * swift format * Collapse BaseRequestContext into RequestContext (#474) * Merge BaseRequestContext and RequestContext into one protocol * swiftformat * Add InstantiableRequestContext * Rename CoreRequestContext to CoreRequestContextStorage (#473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
BaseRequestContextandRequestContextinto one protocolExtract the init into a separate protocol as that is all is needed by Application. This then means someone can use
Applicationand their own responder without being required to keep the context fields we require to useRouterNot sure about name
InstantiableRequestContext, if you have a better name please say