Core request context storage #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
context-source
branch
from
63c7b43
to
2475e72
Compare
adam-fowler
force-pushed
the
core-request-context-storage
branch
from
8583574
to
84c09a4
Compare
adam-fowler
force-pushed
the
core-request-context-storage
branch
from
84c09a4
to
15c1446
Compare
Joannis
approved these changes
Jun 15, 2024
adam-fowler
added a commit
that referenced
this pull request
Jun 15, 2024
…469) * Replace RequestContext initialization parameters with associatedtype * swift format * Collapse BaseRequestContext into RequestContext (#474) * Merge BaseRequestContext and RequestContext into one protocol * swiftformat * Add InstantiableRequestContext * Rename CoreRequestContext to CoreRequestContextStorage (#473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between protocols for context and concrete types that are used in protocols
Would need to do this for auth and websocket as well