Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce the Request context #75

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Re-introduce the Request context #75

merged 4 commits into from
Apr 26, 2021

Conversation

adam-fowler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #75 (243baa1) into main (26fc603) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   82.84%   82.72%   -0.12%     
==========================================
  Files          52       52              
  Lines        2500     2501       +1     
==========================================
- Hits         2071     2069       -2     
- Misses        429      432       +3     
Impacted Files Coverage Δ
...Hummingbird/Server/Application+HTTPResponder.swift 100.00% <100.00%> (ø)
Sources/Hummingbird/Server/Request.swift 94.11% <100.00%> (ø)
Sources/HummingbirdFoundation/Files/FileIO.swift 90.72% <100.00%> (ø)
...s/HummingbirdFoundation/Files/FileMiddleware.swift 92.59% <100.00%> (ø)
Sources/Hummingbird/Utils/HBParser.swift 78.15% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcb6f3...243baa1. Read the comment docs.

* New HBRequestContext protocol

* Fix up FileIO after new HBRequestContext protocol added

* Fix FileTests

* swift format
as ChannelHandlerContext is not thread safe
@adam-fowler adam-fowler merged commit 384c9bd into main Apr 26, 2021
@adam-fowler adam-fowler deleted the request-context branch April 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant