feat/ balancer connector #280

vic-en · 2024-02-13T16:21:28Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Balancer connector.

Tests performed by the developer:

Curl tests
Unit test

Tips for QA testing:

Curl test
End-to-end testing with Hummingbot client.

notion-workspace · 2024-02-13T18:33:17Z

Review Balancer connector

nikspz · 2024-02-14T12:24:11Z

@vic-en Could you please fix failing tests/ add coverage?
https://github.com/hummingbot/gateway/actions/runs/7889551246/job/21530292736?pr=280

nikspz · 2024-02-15T15:03:29Z

Latest development branch + feat/ balancer connector #280
- Test performed:
  - gateway generate certs and yarn start = ok
    - ethereum arbitrum
      - gateway connect balancer = ok
      - checked balance successfully
      - approved WETH and USDC using Client interface
      - create/started amm_arb using balancer ethereum arbitrum
        
        checked status - got warning: Markets are offline for WETH-USDC
        
        Got not realistic PNL for balancer_ethereum_arbitrum to paper_trade
        
        amm/price failed during checking status
        
        curl
        
        amm/price: ok
        
        Reviewed delay before response is about ~10-15 sec
    - ethereum mainnet
      - gateway connect balancer = ok
      - checked balance successfully
      - created amm_arb using balancer ethereum mainnet
    - avalanche_avalanche
      - gateway connect balancer = ok
      - checked balance successfully
      - created amm_arb using balancer avalanche_avalanche
    - polygon_mainnet
      - gateway connect balancer = ok
      - checked balance successfully
      - created amm_arb using balancer polygon_mainnet

Was able to get 1 trade on balancer arbitrum

amm/price failed during checking status

Reviewed delay before response is about ~10-15 sec

nikspz · 2024-02-15T15:04:15Z

@vic-en Could you please fix failing tests/ add coverage for us to be able to check and add it to this release?
https://github.com/hummingbot/gateway/actions/runs/7889551246/job/21530292736?pr=280

vic-en · 2024-02-15T15:24:15Z

@nikspz I'm re-running the tests. I don't think the faillure is due to my change.

vic-en · 2024-02-15T15:32:54Z

FYI @fengtality @nikspz
I believe the workflow file was updated at some point.
I see only ethereum goerli node url is now patched -

gateway/.github/workflows/workflow.yml

Line 81 in be368ed

    
                     sed -i 's/https:\/\/rpc.ankr.com\/eth_goerli/http:\/\/127.0.0.1:8545\//g' ./conf/ethereum.yml

That implies several unit tests will be making call to real node endpoints as defined the the configuration templates.

Aside that, I see several unit tests referencing mainnet. Those are not ideal, especially when no patch in workflow file.

vic-en · 2024-02-15T15:34:32Z

@nikspz You can now see the workflow is passing now and all I did was re-run the workflow.

The hit and miss will always happen due to the numerous unpatched node urls.

nikspz · 2024-03-05T20:08:27Z

We should try with router disabled but we need a the config for that

we have this thing for Uniswap

@vic-en Did you have any chance to check this feature for balancer? Could you please provide some update?

fengtality · 2024-03-05T22:37:57Z

@vic-en I think the hit-and-miss nature of the router means that this connector will need to support the useRouter: false flag to be usable by the community. I think everyone does the same thing with the Uniswap connector.

vic-en · 2024-03-06T18:56:34Z

@fengtality Balancer pools can have several tokens. At thesame time a pair of specific tokens can be availale on several pools.

Unlike uniswap, there will be a challenge of which pool to use as there can be multiple pools with same pair of tokens.

CC @nikspz

i.e Pools filtered for BAL and WETH

…nto feat/balancer-connector

nikspz · 2024-04-11T08:23:24Z

hi @vic-en please fix branch conflicts, update with latest development and continue with this PR

vic-en · 2024-04-11T18:37:19Z

@nikspz Will do and complete this weekend.

…into feat/balancer

…o feat/balancer

vic-en · 2024-04-16T13:02:39Z

@nikspz This is ready.

nikspz · 2024-04-17T05:30:22Z

@vic-en Could you please check failing tests / add coverage?

vic-en · 2024-04-17T13:01:30Z

@nikspz Again, the failling test isn't due to my changes. I mentioned this some time ago - #280 (comment)
Also, another pr has exact failed test as mine - https://github.com/hummingbot/gateway/actions/runs/8714449599/job/23912168538?pr=308

Nevertheless, I can look at that when time permits.

fengtality · 2024-04-17T22:55:37Z

I think this PR fixes the failing tests: #311

nikspz · 2024-04-19T11:44:08Z

Test performed:
- commit 65f4d94
- Cloned and installed balancer gw280 + latest development Client
- gateway generate certs and review gateway ONLINE
- connected balancer connector for
  - ethereum mainnet: ok
  - ethereum arbitrum: ok
  - avalanche: ok
  - polygon: ok
- chain/status: ok
- wallet/add: ok
- amm/price:
  - ethereum mainnet: ok
    - able to get the price
    - some of requests returns Error: Price query failed: No pool found, however checking again after short time was successfull
  - ethereum arbitrum: ok
  - polygon: ok
  - avalanche: "Error: 503 unsupported chain or connector

@vic-en Could you check avalanche? Failed to amm/price for balancer_avalanche_avalanche

…o feat/balancer

vic-en · 2024-04-22T04:39:48Z

@nikspz This is updated. Avalanche now works.

Also, to test with poolId just add the extra poolId in the query like below

Note that you can get poolId from url on that Balancer page

cc @fengtality

nikspz · 2024-04-22T14:17:52Z

We should try with router disabled but we need a the config for that we have this thing for Uniswap

@vic-en
Could poolId be available to use / set / change from Client interface?

I tried to check amm/price works for both with and without poolId

@nikspz This is updated. Avalanche now works.

Confirmed, works now.

avalanche avalanche
- gateway connect balancer avalanche = ok
- checked balance successfully
- checked curl amm/price successfully
- created amm_arb using balancer avalanche successfully

nikspz · 2024-04-22T15:58:44Z

@vic-en

avalanche_avalanche - trade was successful ✔
https://snowtrace.io/tx/0x53483b9fc56f1cf6d7d9c535295372ca04220743ad2f393b2685e97673248688?chainId=43114

amm/trade failing for ethereum_arbitrum ❌
Upon checking reason was - balancer ethereum_arbitrum failed to approve through Client ❌ (Though it returned approved before)

logs_gateway_app.log.2024-04-22.log

https://arbiscan.io/tx/0xd5e5a6c588793f019b58d946e3352092c6d6c906ae9b0fd3eb81f3e664b32835

liquidity/add ❌
"TypeError: uniswapish.addPosition is not a function\n

same error for liquidity/add for balancer_avalanche

vic-en · 2024-04-22T16:51:08Z

@nikspz The LP endpoints for uniswap like contracts cannot work with Balancer. Balancer is different.
The poolId I added is to make swaps to interract with only the pool whose Id is supplied.

Note:

I'll look at the issue with arbitrum approval.
I'll also create a pr on the client to make amm arb configure a poolId
Eta is on/before this weekend.

nikspz · 2024-05-01T19:15:42Z

Note:

I'll look at the issue with arbitrum approval.

I'll also create a pr on the client to make amm arb configure a poolId
Eta is on/before this weekend.

Hi @vic-en Do you have any updates on this one?

vic-en · 2024-05-06T15:23:32Z

@nikspz I'll push the update today.

vic-en · 2024-05-08T05:07:50Z

@nikspz This is ready for testing.
Regarding the failed swaps on arbitrum, they failed due to slippage. Increase the slippage in the configuration file.

…o feat/balancer

fengtality

Approved - Note small typo in logging statement @vic-en

fengtality · 2024-06-02T20:55:44Z

src/connectors/balancer/balancer.ts

+      );
+      if (info.swaps.length === 0) {
+        throw new UniswapishPriceError(
+          `No pool found for ${quoteToken.address} to ${baseToken.address}.`


this should be No pool found for ${baseToken.address} to ${quoteToken.address}.

fengtality · 2024-06-02T20:59:05Z

I will merge this PR into development and address the typo there. The failing tests are due to the Uniswap router used in the tests requiring network access and can be ignored for now.

fengtality and others added 4 commits July 25, 2023 18:35

(feat) re-added changes from hummingbot#130

2c44665

Merge branch 'development' into feat/balancer-connector

d17710a

Merge branch 'development' into feat/balancer-connector

ba9950c

add balancer connector with unit tests

9bcad26

vic-en requested a review from fengtality February 13, 2024 16:21

vic-en changed the title ~~add balancer connector with unit tests~~ feat/ balancer connector with unit tests Feb 13, 2024

vic-en changed the title ~~feat/ balancer connector with unit tests~~ feat/ balancer connector Feb 13, 2024

nikspz self-requested a review February 15, 2024 08:54

nikspz mentioned this pull request Feb 15, 2024

Balancer connector #102

Closed

vic-en and others added 3 commits February 18, 2024 00:04

Merge branch 'development' into feat/balancer

eff70a7

Merge branch 'development' into feat/balancer

c0604e4

Merge branch 'development' into feat/balancer

fdc4598

Merge branch 'development' into feat/balancer

7c6c6f1

This was referenced Apr 6, 2024

Feat/add poolId #305

Closed

feat/ add poolId with unit test. #306

Merged

Merge branch 'development' of https://github.com/hummingbot/gateway i…

18a5a4d

…nto feat/balancer-connector

vic-en added 2 commits April 12, 2024 17:09

wqMerge branch 'development' of https://github.com/hummingbot/gateway …

9aef95c

…into feat/balancer

Merge branch 'feat/balancer' of https://github.com/vic-en/gateway int…

e468d67

…o feat/balancer

vic-en added 2 commits April 15, 2024 14:38

yarn lock update

7c6da0e

yarn lock update

3fcfc89

Merge branch 'development' into feat/balancer

65f4d94

fengtality approved these changes Apr 18, 2024

View reviewed changes

vic-en added 2 commits April 21, 2024 23:31

add avalanche support

c33d1b0

Merge branch 'feat/balancer' of https://github.com/vic-en/gateway int…

59f0d03

…o feat/balancer

price update

07bd1cb

vic-en mentioned this pull request May 8, 2024

Feat/pool id in amm arb hummingbot/hummingbot#7018

Merged

2 tasks

nikspz and others added 3 commits May 17, 2024 18:29

Merge branch 'development' into feat/balancer

59968d9

uniswap acks poolId when supplied

00ec985

Merge branch 'feat/balancer' of https://github.com/vic-en/gateway int…

5fbdaae

…o feat/balancer

vic-en requested a review from fengtality May 20, 2024 19:24

nikspz and others added 3 commits May 21, 2024 03:24

Merge branch 'development' into feat/balancer

a6e94a2

update trade

58c0055

Merge branch 'feat/balancer' of https://github.com/vic-en/gateway int…

8384e51

…o feat/balancer

fengtality approved these changes Jun 2, 2024

View reviewed changes

fengtality merged commit 87a3d66 into hummingbot:development Jun 2, 2024
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/ balancer connector #280

feat/ balancer connector #280

vic-en commented Feb 13, 2024 •

edited

Loading

notion-workspace bot commented Feb 13, 2024

nikspz commented Feb 14, 2024

nikspz commented Feb 15, 2024

nikspz commented Feb 15, 2024

vic-en commented Feb 15, 2024

vic-en commented Feb 15, 2024

vic-en commented Feb 15, 2024

nikspz commented Mar 5, 2024

fengtality commented Mar 5, 2024

vic-en commented Mar 6, 2024 •

edited

Loading

nikspz commented Apr 11, 2024

vic-en commented Apr 11, 2024

vic-en commented Apr 16, 2024

nikspz commented Apr 17, 2024

vic-en commented Apr 17, 2024

fengtality commented Apr 17, 2024

nikspz commented Apr 19, 2024

vic-en commented Apr 22, 2024

nikspz commented Apr 22, 2024 •

edited

Loading

nikspz commented Apr 22, 2024 •

edited

Loading

vic-en commented Apr 22, 2024

nikspz commented May 1, 2024

vic-en commented May 6, 2024

vic-en commented May 8, 2024

fengtality left a comment

fengtality Jun 2, 2024

fengtality commented Jun 2, 2024

feat/ balancer connector #280

feat/ balancer connector #280

Conversation

vic-en commented Feb 13, 2024 • edited Loading

notion-workspace bot commented Feb 13, 2024

nikspz commented Feb 14, 2024

nikspz commented Feb 15, 2024

nikspz commented Feb 15, 2024

vic-en commented Feb 15, 2024

vic-en commented Feb 15, 2024

vic-en commented Feb 15, 2024

nikspz commented Mar 5, 2024

fengtality commented Mar 5, 2024

vic-en commented Mar 6, 2024 • edited Loading

nikspz commented Apr 11, 2024

vic-en commented Apr 11, 2024

vic-en commented Apr 16, 2024

nikspz commented Apr 17, 2024

vic-en commented Apr 17, 2024

fengtality commented Apr 17, 2024

nikspz commented Apr 19, 2024

vic-en commented Apr 22, 2024

nikspz commented Apr 22, 2024 • edited Loading

nikspz commented Apr 22, 2024 • edited Loading

vic-en commented Apr 22, 2024

nikspz commented May 1, 2024

vic-en commented May 6, 2024

vic-en commented May 8, 2024

fengtality left a comment

Choose a reason for hiding this comment

fengtality Jun 2, 2024

Choose a reason for hiding this comment

fengtality commented Jun 2, 2024

vic-en commented Feb 13, 2024 •

edited

Loading

vic-en commented Mar 6, 2024 •

edited

Loading

nikspz commented Apr 22, 2024 •

edited

Loading

nikspz commented Apr 22, 2024 •

edited

Loading