Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ Incorrect balance reporting #2876

Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix/ Incorrect balance reporting #2876

merged 2 commits into from
Jan 28, 2021

Conversation

CrimsonJacket
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Fix Issues:
#2773 #2864

@CrimsonJacket CrimsonJacket self-assigned this Jan 26, 2021
@rxlxrxsx
Copy link
Contributor

rxlxrxsx commented Jan 26, 2021 •
edited
Loading

Tested and confirmed working on Binance. PHB token now showing values on Total USD conversion column.
Screen Shot 2021-01-26 at 4 03 56 PM

USDT still not getting picked up on Bitfinex
Screen Shot 2021-01-26 at 4 50 47 PM

Note: Tokens that are not supported by Binance will still show 0 on the Total USD conversion column which is currently the expected behavior.
Example:
Screen Shot 2021-01-26 at 5 16 57 PM

Screen Shot 2021-01-26 at 5 16 42 PM

@rapcmia
Copy link
Contributor

rapcmia commented Jan 27, 2021

Checked this as well inline with #2773, PHB has now value.
image

@CrimsonJacket
Copy link
Contributor Author

@rxlxrxsx @rapcmia Made some changes to handle specific trading pairs and tokens in BitFinex. This should resolve issues in #2864

rxlxrxsx
rxlxrxsx approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@rxlxrxsx rxlxrxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest commits and confirmed working. USDT token on Bitfinex now showing values on Total USD conversion column.
Screen Shot 2021-01-28 at 12 50 53 PM

Also, when configuring market on Bitfinex it now shows USDT instead of UST which is basically the same token.
Screen Shot 2021-01-28 at 12 59 12 PM

@CrimsonJacket CrimsonJacket merged commit e200fae into development Jan 28, 2021
@CrimsonJacket CrimsonJacket deleted the fix/incorrect_balance_report branch January 28, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxlxrxsx rxlxrxsx rxlxrxsx approved these changes

Assignees

@CrimsonJacket CrimsonJacket

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrimsonJacket @rxlxrxsx @rapcmia