-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/Duration/running time display from the Hummingbot #5499
fix/Duration/running time display from the Hummingbot #5499
Conversation
…k as the Linux uptime
Do you have screenshots by any chance? |
Yes, they are added in the opened issue, but will add them here too |
@theomaniac Could you please fix failing tests? thanks |
Have asked multiple times and multiple people, about how those can be fixed. |
Have anybody looked at the tests it is failing and why ? |
Hi @theomaniac. As I told you before, when you make a change in the code you have to also adapt the test for that. |
@theomaniac Please, change:
It is necessary and very helpful to reviewers and co-developers to implement the appropriate tests to validate the changes made in the PR - modifying existing tests, adding extra tests, removing obsolete tests, etc... Hope this helps, thank you for your contribution (I am just a community beginner dev) |
…k as the Linux uptime, fixed test
Hi @theomaniac Would you please answer if you're able update the PR with tests advised above and be assigned for the bounty here? |
Yeah, will look at the tests |
it seems that managed to fix the test, take a look |
https://github.com/hummingbot/hummingbot/actions/runs/3949619552/jobs/6761212822 |
fixed, finally it seems that we are getting somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests performed:
- Cloned and installed feature branch
- Manually created docker image successfully
- Ran the longterm bot for 3 days
- Reviewed that runtime showing correctly and now displayed days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
When the Hummingbot runs for more than 1 day, the bottom status on the left, displaying the running time, gets messed up.
It fixes the issue described in #5497, also makes the elapsed time more Linux Uptime like
Before:
![2022-07-14-20-08-44](https://user-images.githubusercontent.com/109097532/179053199-e37b54c2-d38a-4830-906e-18386558ce33.png)
After:
![2022-07-14-20-22-43](https://user-images.githubusercontent.com/109097532/179053247-30387c0b-a27e-4b65-8f50-d9e643dbb14c.png)
Tests performed by the developer:
Waited 1 day
Tips for QA testing:
Wait 1 day ;)