-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/configurable cert path #5918
Conversation
PR update:
For Error displaying and handling we have observed that for the client side it still displays the full error. Current commit does not support to only display the endpoint and error message in the client and leave the details on the log file Attached: WindowsTerminal_VH8FCHylqC.mp4 |
…ingbot/hummingbot into feat/configurable_cert_path
Docker installation: Issue fixed no the error showing on the terminal of 1.) Bot showed SSL configuration file not found. Please use Steps:
Actual: Expected: 2.) then restarted the bot, 3.) After certs created, ran Bot showed installation from source, however it was started with ./start.sh (so that's docker installation) |
…ingbot/hummingbot into feat/configurable_cert_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests performed:
- Setup source/docker build on WSL and MacOs, all ok
- Ran simple AMM-arb and check if log files are recorded, all ok
- Setup Source/Docker Build using AWS - OK
- Ran simple AMM-arb and check if log files are recorded, all ok
- Reviewed cert files created for
- source in
home/ubuntu/.hummingbot-gateway/hummingbot-gateway-xxxxxxxxxx/certs
- docker in
home/ubuntu/hummingbot_files/hummingbot_certs
- source in
- gateway Conf and logs created for
- source in
/home/ubuntu/hummingbot/gateway/conf
and/home/ubuntu/concet/gateway/logs
- docker in
home/ubuntu/hummingbot_files/gateway_conf
andhome/ubuntu/hummingbot_files/gateway_logs
- source in
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: