Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/configurable cert path #5918

Merged
merged 24 commits into from
Dec 9, 2022
Merged

Conversation

fengtality
Copy link
Sponsor Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@rapcmia
Copy link
Contributor

rapcmia commented Dec 5, 2022

PR update:

  • As per discussion last maintenance meeting, the error showing on the terminal of no file or directory.. gateway/conf/ssl.yml for both source and docker build should be considered as a warning and fixed after gateway has been successfully setup on the client. Faouzi acknowledged the task and will add update to quietly not display it
    Screenshot 2022-12-05 125403
  • Setup for source client and gateway:
    • Successfully installed client
    • Confirmed hummingbot-gateway-xxx instance only has cert folder
    • New directory for conf and log are now within the ../gateway/ folder
    • Ran gateway generate certs but getting the prompt below. It seems that it assumes the client was running on docker
      Screenshot 2022-12-05 125942
    • Successfully setup client + gateway source build
    • Successfully setup AMM-Arbitrage
    • Tests gateway create
      • Did not prompt us about the command but it forced it self to create a docker image. See screen recording source-1 below
      • This command is designed to automate Gateway setup when you have installed Hummingbot using Docker, but it looks like you have installed Hummingbot from source. Do you want to continue?” (Yes/No)
  • Setup for docker client and gateway:
    • Successfully build docker image for client/gateway for local tests
    • Ran gateway create successfully
    • Test gateway generate_cert on docker build
      • Need to confirm @Faouzijedidi1 if this is the expected behavior? I haven't ran gateway create yet
        Screenshot 2022-12-05 142810

For Error displaying and handling we have observed that for the client side it still displays the full error. Current commit does not support to only display the endpoint and error message in the client and leave the details on the log file
Screenshot 2022-12-05 130405

Attached:
Screen recording source-1

WindowsTerminal_VH8FCHylqC.mp4

@nikspz
Copy link
Contributor

nikspz commented Dec 6, 2022

Docker installation:

Issue fixed no the error showing on the terminal of no file or directory.. gateway/conf/ssl.yml
Gateway generated certs, created in ubuntu/instance_files/hummingbot_certs,
logs and config created in gateway_logs and gateway_conf
connected pangolin key, checked balance and ran simple AMM strategy
checked logs in gateway_logs file recorded

1.) Bot showed SSL configuration file not found. Please use gateway/setup/generate_conf.sh to generate it. after initial gateway generate certs for Docker installation

Steps:

  1. clone and install feature branch
  2. create docker image manually
  3. ./create.sh / ./start.sh docker instance of the bot
  4. run gateway generate certs

Actual:
Bot showed promts/hints for Docker installation
(Bot showed SSL configuration file not found. Please use gateway/setup/generate_conf.sh to generate it.after initialgateway generate certs)
certs created in ubuntu/instance_files/hummingbot_certs

Expected:
Bot showed promts/hints for Docker installation
certs created in ubuntu/instance_files/hummingbot_certs

conf certs Docker

2.) then restarted the bot, bot can't find that certs already created

image

then restarted the bot, bot can't find that certs already created

3.) After certs created, ran gateway create bot can't see that we use Docker installation (started with ./start.sh)

image

Bot showed installation from source, however it was started with ./start.sh (so that's docker installation)

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests performed:

  • Setup source/docker build on WSL and MacOs, all ok
  • Ran simple AMM-arb and check if log files are recorded, all ok
  • Setup Source/Docker Build using AWS - OK
  • Ran simple AMM-arb and check if log files are recorded, all ok
  • Reviewed cert files created for
    • source in home/ubuntu/.hummingbot-gateway/hummingbot-gateway-xxxxxxxxxx/certs
    • docker in home/ubuntu/hummingbot_files/hummingbot_certs
  • gateway Conf and logs created for
    • source in /home/ubuntu/hummingbot/gateway/conf and /home/ubuntu/concet/gateway/logs
    • docker in home/ubuntu/hummingbot_files/gateway_conf and home/ubuntu/hummingbot_files/gateway_logs

@JeremyKono JeremyKono merged commit 4063ba1 into development Dec 9, 2022
@JeremyKono JeremyKono deleted the feat/configurable_cert_path branch December 9, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants