Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateio derivative position error #6551

Conversation

yancong001
Copy link
Contributor

@yancong001 yancong001 commented Aug 29, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
link to #6539
#6510

Tests performed by the developer:

dev-1.19, tested with perpetual_market_making strategy

Tips for QA testing:

@rapcmia rapcmia self-requested a review August 29, 2023 11:47
@nikspz
Copy link
Contributor

nikspz commented Aug 30, 2023

@yancong001 Could you please fix failing tests (add coverage)?

@rapcmia
Copy link
Contributor

rapcmia commented Aug 31, 2023

PR update:

  • Test latest commit 5de82f82547fea
  • Successfully opened a position
  • Stop/exit the client and check if position will be retrieved when started again ✅
  • Open a position manually and start perp-mm on client ✅
  • When a position is open with take-profit order created, run exit -f:
    • Relaunch client and run the strategy again, able to retrieve the position and cancel the existing order that was left due to force exit
  • Build docker image and ran same tests ✅

Note: PR good to be approved, thank you 🙇🏼


Github workflow failed due to:
image

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit 6c04a5d into hummingbot:development Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants