Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gateio derivative position error #6551

Merged
merged 10 commits into from Sep 4, 2023
Merged

fix gateio derivative position error #6551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7571e89
fix error
Aug 29, 2023
da1e22b
Merge branch 'development' into fix/gateio_perpetual_position_error
yancong001 Aug 29, 2023
644a535
Merge branch 'development' into fix/gateio_perpetual_position_error
nikspz Aug 30, 2023
24b347d
Merge branch 'development' into fix/gateio_perpetual_position_error
rapcmia Aug 31, 2023
5de82f8
add unittest
Aug 31, 2023
b6cc57c
update unittest
Sep 1, 2023
a450862
update unittest
Sep 1, 2023
5278a18
update unittest
Sep 1, 2023
4bd7fbb
Merge branch 'development' into fix/gateio_perpetual_position_error
rapcmia Sep 1, 2023
cfb24a5
Merge branch 'development' into fix/gateio_perpetual_position_error
cardosofede Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions hummingbot/connector/derivative/gate_io_perpetual/gate_io_perpetual_derivative.py
View file
Open in desktop
Expand Up @@ -703,9 +703,14 @@ async def _update_positions(self):
hb_trading_pair = await self.trading_pair_associated_to_exchange_symbol(ex_trading_pair)

amount = Decimal(position.get("size"))
position_side = PositionSide.LONG if Decimal(position.get("size")) > 0 else PositionSide.SHORT

pos_key = self._perpetual_trading.position_key(hb_trading_pair, position_side)
ex_mode = position.get("mode")
if ex_mode == 'single':
mode = PositionMode.ONEWAY
position_side = PositionSide.LONG if Decimal(position.get("size")) > 0 else PositionSide.SHORT
else:
mode = PositionMode.HEDGE
position_side = PositionSide.LONG if ex_mode == "dual_long" else PositionSide.SHORT
pos_key = self._perpetual_trading.position_key(hb_trading_pair, position_side, mode)

if amount != 0:
trading_rule = self._trading_rules[hb_trading_pair]
Expand Down
93 changes: 93 additions & 0 deletions test/hummingbot/connector/derivative/gate_io_perpetual/test_gate_io_perpetual_derivative.py
View file
Open in desktop
Expand Up @@ -843,13 +843,15 @@ def configure_successful_set_position_mode(
"user": 1666,
"currency": "USDT",
"total": "9707.803567115145",
"size": "9707.803567115145",
"unrealised_pnl": "3371.248828",
"position_margin": "38.712189181",
"order_margin": "0",
"available": "9669.091377934145",
"point": "0",
"bonus": "0",
"in_dual_mode": True if position_mode is PositionMode.HEDGE else False,
"mode": "single" if position_mode is PositionMode.ONEWAY else "dual_long",
"history": {
"dnw": "10000",
"pnl": "68.3685",
Expand Down Expand Up @@ -1710,3 +1712,94 @@ def test_create_buy_limit_maker_order_successfully(self, mock_api):
f"{Decimal('100.000000')} to {PositionAction.OPEN.name} a {self.trading_pair} position."
)
)

@aioresponses()
def test_update_position_mode(
self,
mock_api: aioresponses,
):
self._simulate_trading_rules_initialized()
get_position_url = web_utils.public_rest_url(
endpoint=CONSTANTS.POSITION_INFORMATION_URL
)
regex_get_position_url = re.compile(f"^{get_position_url}")
response = [
{
"user": 10000,
"contract": "BTC_USDT",
"size": 9440,
"leverage": "0",
"risk_limit": "100",
"leverage_max": "100",
"maintenance_rate": "0.005",
"value": "2.497143098997",
"margin": "4.431548146258",
"entry_price": "3779.55",
"liq_price": "99999999",
"mark_price": "3780.32",
"unrealised_pnl": "-0.000507486844",
"realised_pnl": "0.045543982432",
"history_pnl": "0",
"last_close_pnl": "0",
"realised_point": "0",
"history_point": "0",
"adl_ranking": 5,
"pending_orders": 16,
"close_order": {
"id": 232323,
"price": "3779",
"is_liq": False
},
"mode": "single",
"update_time": 1684994406,
"cross_leverage_limit": "0"
}
]
mock_api.get(regex_get_position_url, body=json.dumps(response))
self.async_run_with_timeout(self.exchange._update_positions())

position: Position = self.exchange.account_positions[self.trading_pair]
self.assertEqual(self.trading_pair, position.trading_pair)
self.assertEqual(PositionSide.LONG, position.position_side)

get_position_url = web_utils.public_rest_url(
endpoint=CONSTANTS.POSITION_INFORMATION_URL
)
regex_get_position_url = re.compile(f"^{get_position_url}")
response = [
{
"user": 10000,
"contract": "BTC_USDT",
"size": 9440,
"leverage": "0",
"risk_limit": "100",
"leverage_max": "100",
"maintenance_rate": "0.005",
"value": "2.497143098997",
"margin": "4.431548146258",
"entry_price": "3779.55",
"liq_price": "99999999",
"mark_price": "3780.32",
"unrealised_pnl": "-0.000507486844",
"realised_pnl": "0.045543982432",
"history_pnl": "0",
"last_close_pnl": "0",
"realised_point": "0",
"history_point": "0",
"adl_ranking": 5,
"pending_orders": 16,
"close_order": {
"id": 232323,
"price": "3779",
"is_liq": False
},
"mode": "dual_long",
"update_time": 1684994406,
"cross_leverage_limit": "0"
}
]
mock_api.get(regex_get_position_url, body=json.dumps(response))
self.async_run_with_timeout(self.exchange._update_positions())
position: Position = self.exchange.account_positions[f"{self.trading_pair}LONG"]
self.assertEqual(self.trading_pair, position.trading_pair)
self.assertEqual(PositionSide.LONG, position.position_side)