-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/injective low leve api components #6811
Feat/injective low leve api components #6811
Conversation
… are all in Dict format
…moa/hummingbot into feat/injective_low_leve_api_components
…moa/hummingbot into feat/injective_low_leve_api_components
… orders in successful TXs for MsgBatchUpdateOrders
…he new endpoint used to fetch TXs data
…to feat/injective_low_leve_api_components
…amp directly in the datasource
…amp directly in the datasource
…ake fee estimation configurable. The user can choose to calculate gas fee using simulation or use the Python SDK message based gas fee estimation
…to feat/injective_low_leve_api_components
…to feat/injective_low_leve_api_components
…tor configuration
…to feat/injective_low_leve_api_components
…to feat/injective_low_leve_api_components
…to feat/injective_low_leve_api_components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@nikspz code review ready, please run the test that @aarmoa requested and ask any questions that you have around the fee calculation. |
PR update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
-
commit e9f9b75..
-
connect injective_v2 successfully for both spot and perpetuals
-
Confirmed new parameters added
-
Injective_v2 (spot)
- testnet on
- simulated_tx_fee_calculator: ok
- message_based_tx_fee_calculator: ok
- mainnet
- simulated_tx_fee_calculator:
- setup pureMM strategy and did trades successfully
- review history: ok, fees matched with the Helix app exchange
- message_based_tx_fee_calculator:
- setup pureMM strategy and did trades successfully
- ok, fees matched with the Helix app exchange
- simulated_tx_fee_calculator:
- testnet on
-
Injective_perpetaul_v2 on mainnet
- simulated_tx_fee_calculator: ok, fees matched using PerpetualMM strategy with the Helix app exchange
- message_based_tx_fee_calculator: ok, fees matched using PerpetualMM strategy with the Helix app exchange
Note: issue that Ralph reported #6824 reproduced on mainnet spot and perpetual. This part could be improved by Injective.
As Abel reported, issue related to the public node we use and not related to this PR
However, was able to trade using V1 strategies and delegate_account mode
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
All unit tests passing in green.
Spot and perpetual connectors were tested also by running bots connected to testnet, both using delegated accounts and vaults.
Tips for QA testing:
This PR is associated to the docs update in hummingbot/hummingbot-site#338