Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project build failed due to breaking changes in pnpm v9 #163

Closed
hunghvu opened this issue Apr 21, 2024 · 1 comment · Fixed by #164
Closed

Project build failed due to breaking changes in pnpm v9 #163

hunghvu opened this issue Apr 21, 2024 · 1 comment · Fixed by #164
Labels
bug Something isn't working build
Milestone
v1.3

Comments

@hunghvu
Copy link
Owner

hunghvu commented Apr 21, 2024

Dockerfile always install the latest version of pnpm.

ERR_PNPM_BAD_PM_VERSION  This project is configured to use v8.15.1 of pnpm. Your current pnpm is v9.0.4

Related: pnpm/pnpm#7934
@hunghvu hunghvu added bug Something isn't working build labels Apr 21, 2024
@hunghvu hunghvu added this to the v1.3 milestone Apr 21, 2024
hunghvu added a commit that referenced this issue Apr 21, 2024
@hunghvu
build: update pnpm lockfile to v9, related to #163
52009c1
@hunghvu
Copy link
Owner Author

hunghvu commented Apr 21, 2024 •
edited

We may need to remove packageManager field.

  • Or, make it not version specific (e.g.., something like ^), or else, the build will fail when pnpm has a new minor version.
  • Or, just pin pnpm version in Dockerfile.

Related: https://github.com/pnpm/pnpm/releases/tag/v9.0.0

hunghvu added a commit that referenced this issue Apr 21, 2024
@hunghvu
build: pin pnpm version, related to #163
2d3507e
@hunghvu hunghvu mentioned this issue Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Fix build fail due to breaking changes in pnpm v9 hunghvu/hungvu.tech
1 participant
@hunghvu