Skip to content

Commit

Permalink
Remove the CHECK when we fail to set the DXVA decoder output type.
Browse files Browse the repository at this point in the history
This CHECK fires intermittently and appears to be caused by buggy drivers and or AV malware combinations. In most of the crashes, I debugged, the failure was MF_E_INVALIDMEDIATYPE which indicates that the driver does not support H.264 decoding.

In any case this code has now baked for a while on the field for DX11 and Win8+. So it should be ok to remove the CHECK

BUG=588358
R=sandersd

Review URL: https://codereview.chromium.org/1770223002

Cr-Commit-Position: refs/heads/master@{#379704}
  • Loading branch information
ananta authored and Commit bot committed Mar 8, 2016
1 parent 5e534ef commit 61b99f6
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions content/common/gpu/media/dxva_video_decode_accelerator_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2448,12 +2448,6 @@ bool DXVAVideoDecodeAccelerator::SetTransformOutputType(
RETURN_ON_HR_FAILURE(hr, "Failed to set media type attributes", false);
}
hr = transform->SetOutputType(0, media_type.get(), 0); // No flags
if (FAILED(hr)) {
base::debug::Alias(&hr);
// TODO(ananta)
// Remove this CHECK when this stabilizes in the field.
CHECK(false);
}
RETURN_ON_HR_FAILURE(hr, "Failed to set output type", false);
return true;
}
Expand Down

0 comments on commit 61b99f6

Please sign in to comment.