Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A judgment #9

Closed
yuagonc opened this issue Jun 9, 2020 · 1 comment
Closed

A judgment #9

yuagonc opened this issue Jun 9, 2020 · 1 comment

Comments

@yuagonc
Copy link

yuagonc commented Jun 9, 2020 •
edited

I use cf-worker version and close "cnpmjs" ,when I visit home page, it occur an error:

cfworker error:
TypeError: Cannot read property 'href' of null
at proxy (worker.js:135:36)
at httpHandler (worker.js:125:12)
at fetchHandler (worker.js:73:16)
at worker.js:49:17

I found the error code:
if(path.search(exp1) === 0 || !Config.cnpmjs && (path.search(exp3) === 0 || path.search(exp4))) I have read and tested code, I think it may should be:
if (path.search(exp1) === 0 || !Config.cnpmjs && (path.search(exp3) === 0 || path.search(exp4) === 0))

hunshcn added a commit that referenced this issue Jun 9, 2020
@hunshcn
fix index.js, issue #9
a89845f
@hunshcn
Copy link
Owner

hunshcn commented Jun 9, 2020

a89845f fixed

@yuagonc yuagonc closed this as completed Jun 9, 2020
libsgh pushed a commit to libsgh/gh-proxy that referenced this issue Feb 5, 2024
@hunshcn
fix index.js, issue hunshcn#9
99e3f75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hunshcn @yuagonc