Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven artifact jdom-sources includes the source for tests, and samples, not just the core. #150

Closed
rolfl opened this issue Nov 14, 2015 · 1 comment

Comments

@rolfl
Copy link
Collaborator

rolfl commented Nov 14, 2015

The Maven artifact deployed is just the core JDOM library, but the accompanying source jar contains the unit tests and sample/contrib code (which is not in the compiled/deployed jar).

To prevent issues where people expect to see all the classes in the source jar compiled in to the compiled jar, the unused sources should be removed

@hakanai
Copy link

hakanai commented Aug 4, 2017

The classes for the tests are also in the jdom2 jar too... this seems like a slip-up.

.../jdom2-2.0.6.jar
  org.jdom2.test.cases
    TestAttribute
      test_TCM__boolean_equals_Object()
        assertFalse("attribute equal to null", attribute.equals(null));
      test_TCM__int_hashCode()
        assertFalse("Different Attributes with same value have same hashcode", x == i);
        assertFalse("Different Attributes have same hashcode", y == x);
        import static org.junit.Assert.assertFalse;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants