Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Show GitHub checks status when merging #84

Closed
sstok opened this issue Apr 26, 2020 · 1 comment · Fixed by #88
Closed

[Feature] Show GitHub checks status when merging #84

sstok opened this issue Apr 26, 2020 · 1 comment · Fixed by #88
Labels
Feature

Comments

@sstok
Copy link
Member

sstok commented Apr 26, 2020 •
edited
Loading

Description
When using TravisCI the build-status is shown in the status table of the merge command but GitHub checks are not shown here?

Example

| Item                      | Status | Details                   |
|---------------------------|--------|---------------------------|
| Full CI process / PHP 7.1 | OK     | Successful in 2m          |
| Full CI process / PHP 7.2 | OK     | Successful in 2m          |
| Full CI process / PHP 7.3 | OK     | Successful in 2m          |
| Full CI process / PHP-QA  | Failed | Failing after 1m — PHP-QA |
| Scrutinizer               | OK     | No new issues             |
@sstok sstok added the Feature label Apr 26, 2020
@sstok sstok changed the title [Feature] Show GitHub actions status when merging [Feature] Show GitHub checks status when merging Apr 26, 2020
@sstok
Copy link
Member Author

sstok commented Apr 26, 2020

For reference this is an experimental feature https://developer.github.com/v3/checks/runs/#list-check-runs-for-a-git-reference and depends on KnpLabs/php-github-api#865

@acrobat acrobat mentioned this issue Nov 14, 2020
Merged
@sstok sstok closed this as completed in #88 Nov 15, 2020
sstok added a commit that referenced this issue Nov 15, 2020
@sstok
feature #88 Add support for github checks api in merge handler (acrobat)
32a5bf9 
This PR was merged into the 1.0-dev branch.

Discussion
----------

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tickets       | Fixes #84 
| License       | MIT

While switch the build of knplabs/php-github-api from travisci to github actions, I noticed that the github actions results didn't show up during a merge. This was because of github action build results being reported as checks.

So this PR add support for checks to be displayed, alongside with commit statusses as checks are only available through github apps. So it's possible that a commit/pr has both statusses and checks.

Example output for a PR with statusses and checks (styleci is a status and all others are checks)
![image](https://user-images.githubusercontent.com/1374857/99152927-52783100-26a5-11eb-89ff-b0e622adc633.png)


Commits
-------

dd6f59f Add support for github checks api in merge handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for github checks api in merge handler acrobat/hubkit
1 participant
@sstok