Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional check run methods #865

Merged
merged 3 commits into from
Jul 11, 2020
Merged

Conversation

bobeagan
Copy link
Contributor

fixes #864

@acrobat
Copy link
Collaborator

acrobat commented Apr 25, 2020

Looks good @bobeagan, can you just add some basic tests to have some coverage for these methods? Thanks!

@GrahamCampbell
Copy link
Contributor

This needs re-targetting to 2.x.

@acrobat acrobat changed the base branch from master to 2.x July 11, 2020 15:40
@acrobat acrobat merged commit 0e74e30 into KnpLabs:2.x Jul 11, 2020
@acrobat
Copy link
Collaborator

acrobat commented Jul 11, 2020

I've added the missing tests and changed the base branch. Thanks @bobeagan for the initial work!

acrobat added a commit that referenced this pull request Jul 11, 2020
* 2.x:
  Update changelog for 2.15.0 release
  Remove description line from changelog to allow automatic update
  feature #865 add additional check run methods (bobeagan, acrobat)
@bobeagan bobeagan deleted the 864/update-check-runs branch July 17, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checks / check-runs support
3 participants