Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added env var to allow a 7cm forward bumper extension #92

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Added env var to allow a 7cm forward bumper extension #92

merged 4 commits into from
Aug 7, 2018

Conversation

guystoppi
Copy link
Contributor

No description provided.

@tonybaltovski
Copy link
Member

@jeff-o Is this what you had in mind for the bumper extension?

@tonybaltovski
Copy link
Member

@Nirzvi1 we'd prefer to input a value for the extension length rather than true/false for a fixed value.

@guystoppi
Copy link
Contributor Author

@tonybaltovski
The env var is now used as the length of the extension in centimetres, defaulting to zero.

@tonybaltovski tonybaltovski merged commit 5f1e46c into husky:kinetic-devel Aug 7, 2018
@tonybaltovski
Copy link
Member

Thanks @Nirzvi1 !

dkati pushed a commit to dkati/husky that referenced this pull request Sep 4, 2018
@guystoppi @dkati
Added env var to allow a 7cm forward bumper extension (husky#92)
65f8340 
* Added env var to allow for extendable front bumper

* Fix weird spacing

* Uploaded bumper extension meshes

* Allowed for different lengths of bumper extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guystoppi @tonybaltovski