added interceptor option #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
pete911: I really like this idea. Since we are using variadic parameters this should be a no-op change. If you don't mind, please add some documentation in the README.md showcasing this functionality, as well as adding sufficient test coverage to fully cover this addition. Thanks so much for adding this functionality! |
|
Thanks! will do it first thing tomorrow morning |
added 2 commits
May 24, 2017 16:56
|
Hi, have a look at the code, let me know what you think. Plus not sure why CI is failing, I should have 100% coverage of the code that I added. Thanks |
|
LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to illustrate adding interceptors without having impact on existing users. This adds ability to add authentication interceptor, access log interceptor etc.