Revert "[DDP] Rename num_iterations -> num_forward_calls (pytorch#103283

)" This reverts commit a3a32c1.
huydhn · Jun 20, 2023 · 802be1c · 802be1c
1 parent 0aa680c
commit 802be1c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/torch/nn/parallel/distributed.py b/torch/nn/parallel/distributed.py
@@ -254,7 +254,7 @@ def forward(ctx, reducer, ddp_state, *inputs):
     def backward(ctx, *grad_outputs):
         # Enqueue delay allreduce for static graph training on the first
         # iteration.
-        if ctx.ddp_state["static_graph"] and ctx.ddp_state["num_forward_calls"] == 1:
+        if ctx.ddp_state["static_graph"] and ctx.ddp_state["num_iterations"] == 1:
             Variable._execution_engine.queue_callback(  # type: ignore[call-arg,misc]
                 ctx.reducer._delay_all_reduce
             )
@@ -1047,7 +1047,7 @@ def _ddp_init_helper(
         (4) Logging construction-time DDP logging data
         (5) passing a handle of DDP to SyncBatchNorm Layer
         """
-        self.num_forward_calls = 0
+        self.num_iterations = 0
         # Notice, the parameters order is not in the order in which they are used,
         # especially in models with control flow.
         #
@@ -1381,7 +1381,7 @@ def _pre_forward(self, *inputs, **kwargs):
         if torch.is_grad_enabled() and self.require_backward_grad_sync:
             assert self.logger is not None
             self.logger.set_runtime_stats_and_log()
-            self.num_forward_calls += 1
+            self.num_iterations += 1
             self.reducer.prepare_for_forward()
 
         # Notify the join context that this process has not joined, if
@@ -1466,11 +1466,11 @@ def _post_forward(self, output):
         # TODO: DDPSink is currently enabled for unused parameter detection and
         # static graph training for first iteration.
         if (self.find_unused_parameters and not self.static_graph) or (
-            self.static_graph and self.num_forward_calls == 1
+            self.static_graph and self.num_iterations == 1
         ):
             ddp_state = {
                 "static_graph": self.static_graph,
-                "num_forward_calls": self.num_forward_calls,
+                "num_iterations": self.num_iterations,
             }
 
             (