[DDP] Rename num_iterations -> num_forward_calls #103283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more accurately represents what we're counting. At iteration is a forward + backward call, but here we're just counting forward calls. This makes things less confusing in future diffs where we support DDP static graph multiple forwards. Differential Revision: [D46580601](https://our.internmc.facebook.com/intern/diff/D46580601/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103283
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Unrelated FailuresAs of commit 4606b0e: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 3f6f508:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rohan-varma
added a commit
that referenced
this pull request
Jun 9, 2023
This more accurately represents what we're counting. At iteration is a forward + backward call, but here we're just counting forward calls. This makes things less confusing in future diffs where we support DDP static graph multiple forwards. Differential Revision: [D46580601](https://our.internmc.facebook.com/intern/diff/D46580601/) ghstack-source-id: 191683465 Pull Request resolved: #103283
This was referenced Jun 9, 2023
Closed
huydhn
added a commit
to huydhn/pytorch
that referenced
this pull request
Jun 20, 2023
)" This reverts commit a3a32c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This more accurately represents what we're counting. At iteration is a
forward + backward call, but here we're just counting forward calls. This makes
things less confusing in future diffs where we support DDP static graph
multiple forwards.
Differential Revision: D46580601