Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to pypi tarball #1011

Closed
asagratini opened this issue Jun 21, 2023 · 1 comment · Fixed by #1015
Closed

Add tests to pypi tarball #1011

asagratini opened this issue Jun 21, 2023 · 1 comment · Fixed by #1015
Assignees
Labels
meta related to meta-discussions around this module / project tests related to tests (not necessarily CI/CD)
Milestone

Comments

@asagratini
Copy link

Hello team,
while working on updating hvac version FreeBSD port [1], we noticed that tarball downloaded from pypi.org does not have test suite, which is instead available on this github repo.

Ideally, we'd like to have that included also in pypi file: is this something you can consider adding?

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272060

Let us know if you need anything else.
Thank you

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 21, 2023
 - Switch to DISTVERSION
 - Switch to pep517 build
 - Remove test target because PYPI tarball doesn't include tests:
   hvac/hvac#1011

ChangeLog:	https://github.com/hvac/hvac/blob/v1.1.1/CHANGELOG.md
PR:		272060
@briantist briantist self-assigned this Jun 21, 2023
@briantist briantist added meta related to meta-discussions around this module / project tests related to tests (not necessarily CI/CD) labels Jun 21, 2023
@briantist briantist added this to the 1.2.0 milestone Jun 21, 2023
@briantist
Copy link
Contributor

Hi @asagratini , thanks for opening this!

This seems reasonable and I'll look to add this. I did a little bit of preliminary research and from what I can tell adding tests to the sdist is pretty common, since we're using poetry I guess we will do it somewhat as described here:

If you have any additional background or information that would be helpful too. I'm particularly interested in whether previous versions of hvac did include the tests, so I can try to understand why/how they were removed.

I suspect it may have been an unintended consequence of us moving to poetry:

Since we've already merged some changes to main that require a minor version, the next expected version of hvac is 1.2.0, and I'll look to get this resolved for that release if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta related to meta-discussions around this module / project tests related to tests (not necessarily CI/CD)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants