Add database secret engine

[Dudesons]

Hi @jeffwecan,

I add some code to be able to manage the database backend.
I'm beginning to see how to write integration test, but I have to start another third party service (the database).
How can I integrate it ?

[jeffwecan]

Howdy @Dudesons, thanks for the PR! I'm not sure what would make sense for this project in terms of a full-blown database engine integration test (e.g., any solution would need to be viable for both local developer environments and the travis-ci builds run during PRs). However I'm happy to explore what avenues we might have available to handle such a thing and I'll share anything I discover here.

[codecov-io]

Codecov Report

Merging #431 into develop will decrease coverage by 1.43%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #431      +/-   ##
===========================================
- Coverage    90.14%   88.71%   -1.44%     
===========================================
  Files           46       47       +1     
  Lines         2406     2445      +39     
===========================================
  Hits          2169     2169              
- Misses         237      276      +39

Impacted Files	Coverage Δ
hvac/api/secrets_engines/database.py	0% <0%> (ø)

[Dudesons]

Hi, @jeffwecan
I would like to know what do you want to merge this pr ?

[jeffwecan]

We can go ahead and merge things as-is. I'll see about backfilling some tests before including these changes in the next hvac release (which I'll hopefully get time to complete over the next week or so).

[doszeta]

Hello, hvac team, I am getting errors when calling generate_credentials() in hvac0.9.1.

source: new_key_dict = orphan_hvac_client.secrets.database.generate_credentials(name=role,
mount_point=service_creds_path)
Exception:
File "/usr/local/lib/python3.7/site-packages/hvac/api/vault_api_category.py", line 42, in getattr
raise NotImplementedError('"%s" auth method class not currently implemented.')

Can you confirm if this is a true issue? @Dudesons

[drewmullen]

Hey @doszeta

Yeah this is a known issue: #454

With a fix hopefully being released this week: #455