Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database secret engine #431

Merged
merged 2 commits into from May 7, 2019

Conversation

5 participants
@Dudesons
Copy link
Contributor

commented May 3, 2019

Hi @jeffwecan,

I add some code to be able to manage the database backend.
I'm beginning to see how to write integration test, but I have to start another third party service (the database).
How can I integrate it ?

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Howdy @Dudesons, thanks for the PR! I'm not sure what would make sense for this project in terms of a full-blown database engine integration test (e.g., any solution would need to be viable for both local developer environments and the travis-ci builds run during PRs). However I'm happy to explore what avenues we might have available to handle such a thing and I'll share anything I discover here.

@codecov-io

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #431 into develop will decrease coverage by 1.43%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #431      +/-   ##
===========================================
- Coverage    90.14%   88.71%   -1.44%     
===========================================
  Files           46       47       +1     
  Lines         2406     2445      +39     
===========================================
  Hits          2169     2169              
- Misses         237      276      +39
Impacted Files Coverage Δ
hvac/api/secrets_engines/database.py 0% <0%> (ø)
@Dudesons

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Hi, @jeffwecan
I would like to know what do you want to merge this pr ?

@jeffwecan

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

We can go ahead and merge things as-is. I'll see about backfilling some tests before including these changes in the next hvac release (which I'll hopefully get time to complete over the next week or so).

@jeffwecan jeffwecan added the database label May 7, 2019

@jeffwecan jeffwecan added this to the 0.8.3 milestone May 7, 2019

Ensure Classes for All Auth Methods and Secret Engines automation moved this from In progress to Reviewer approved May 7, 2019

@jeffwecan jeffwecan merged commit cf914b4 into hvac:develop May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Ensure Classes for All Auth Methods and Secret Engines automation moved this from Reviewer approved to Done May 7, 2019

@blancsys blancsys referenced this pull request May 8, 2019

Closed

Database Engine #387

@doszeta

This comment has been minimized.

Copy link

commented Jun 7, 2019

Hello, hvac team, I am getting errors when calling generate_credentials() in hvac0.9.1.

source: new_key_dict = orphan_hvac_client.secrets.database.generate_credentials(name=role,
mount_point=service_creds_path)
Exception:
File "/usr/local/lib/python3.7/site-packages/hvac/api/vault_api_category.py", line 42, in getattr
raise NotImplementedError('"%s" auth method class not currently implemented.')

Can you confirm if this is a true issue? @Dudesons

@drewmullen

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Hey @doszeta

Yeah this is a known issue: #454

With a fix hopefully being released this week: #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.