Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update reference to removed method #942

Merged
merged 1 commit into from
Feb 1, 2023
Merged

doc: update reference to removed method #942

merged 1 commit into from
Feb 1, 2023

Conversation

bendem
Copy link
Contributor

@bendem bendem commented Jan 24, 2023

Resolves #900

@bendem bendem requested a review from a team as a code owner January 24, 2023 14:44
@adammike
Copy link
Member

This looks appropriate to me, @briantist do you have any thoughts?

@briantist briantist self-assigned this Jan 27, 2023
@briantist briantist added the documentation documentation updates and/or requests for expanded documentation label Jan 27, 2023
@briantist briantist added this to the 1.1.0 milestone Jan 27, 2023
@briantist
Copy link
Contributor

Also looks good to me!
@bendem could I trouble you to rebase? The CI should be fixed in #933

@bendem
Copy link
Contributor Author

bendem commented Jan 31, 2023

Sorry for the delay, was off the last few days. PR is rebased now. ;)

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #942 (bab9495) into develop (a98cbf8) will increase coverage by 1.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #942      +/-   ##
===========================================
+ Coverage    81.64%   83.42%   +1.77%     
===========================================
  Files           65       65              
  Lines         3002     2968      -34     
===========================================
+ Hits          2451     2476      +25     
+ Misses         551      492      -59     
Impacted Files Coverage Δ
hvac/v1/__init__.py 85.61% <ø> (-1.65%) ⬇️
hvac/api/vault_api_category.py 94.44% <0.00%> (-0.68%) ⬇️
hvac/adapters.py 86.45% <0.00%> (-0.28%) ⬇️
hvac/utils.py 77.06% <0.00%> (-0.21%) ⬇️
hvac/api/secrets_engines/identity.py 93.98% <0.00%> (-0.03%) ⬇️
hvac/api/auth_methods/mfa.py 100.00% <0.00%> (ø)
hvac/api/secrets_engines/kv.py 100.00% <0.00%> (ø)
hvac/api/system_backend/namespace.py 83.33% <0.00%> (+33.33%) ⬆️
hvac/api/secrets_engines/transform.py 72.65% <0.00%> (+42.96%) ⬆️

@briantist briantist merged commit 29cf9d0 into hvac:develop Feb 1, 2023
@bendem bendem deleted the bendem-patch-1 branch February 2, 2023 14:27
briantist pushed a commit to briantist/hvac that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation updates and/or requests for expanded documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Client.renew_self_token' method is lost
3 participants