Support Antlr4 syntax #208

baruchiro · 2018-11-11T12:18:55Z

Antlr4 use csproj file to generate his files.
Just copy the ItemGroup from old to new.

hvanbakel · 2018-11-11T14:37:52Z

I will need a bit more info then that, can you share a part of your csproj that has the files? Or maybe a minimal csproj in a zip with all the files?

…

On Sun, Nov 11, 2018, 04:18 Baruch Rothkoff ***@***.*** wrote: Antlr4 use csproj file to generate his files. Just copy the ItemGroup from old to new. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#208>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD8FPJ1DcsAi-hjcz6Jwzgnkm-7zNyqGks5uuBWvgaJpZM4YYdLl> .

baruchiro · 2018-11-12T13:33:56Z

Before:

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props" Condition="Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props')" />
  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
  <PropertyGroup>
    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
    <ProjectGuid>{AC708E4D-2737-4D78-AA3D-2E42A48F4F51}</ProjectGuid>
    <OutputType>Library</OutputType>
    <AppDesignerFolder>Properties</AppDesignerFolder>
    <RootNamespace>ProjectName</RootNamespace>
    <AssemblyName>ProjectName</AssemblyName>
    <TargetFrameworkVersion>v4.7.1</TargetFrameworkVersion>
    <FileAlignment>512</FileAlignment>
    <SccProjectName>SAK</SccProjectName>
    <SccLocalPath>SAK</SccLocalPath>
    <SccAuxPath>SAK</SccAuxPath>
    <SccProvider>SAK</SccProvider>
    <TargetFrameworkProfile />
    <NuGetPackageImportStamp>
    </NuGetPackageImportStamp>
  </PropertyGroup>
  .
  .
  .
  <ItemGroup>
    <Reference Include="Antlr4.Runtime, Version=4.6.0.0, Culture=neutral, PublicKeyToken=e9931a4108ef2354, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Antlr4.Runtime.4.6.5-rc002\lib\net45\Antlr4.Runtime.dll</HintPath>
      <Private>True</Private>
    </Reference>
    .
    .
    .
    <Reference Include="System" />
    <Reference Include="System.Core" />
  </ItemGroup>
   .
   .
   .
  <ItemGroup>
    <Antlr4 Include="filename1.g4">
      <Generator>MSBuild:Compile</Generator>
      <TargetLanguage>CSharp_v4_5</TargetLanguage>
      <CustomToolNamespace>myFramework</CustomToolNamespace>
    </Antlr4>
    <Antlr4 Include="filename2.g4">
      <Generator>MSBuild:Compile</Generator>
      <TargetLanguage>CSharp_v4_5</TargetLanguage>
      <CustomToolNamespace>myFramework</CustomToolNamespace>
    </Antlr4>
    <None Include="app.config" />
    <None Include="packages.config" />
  </ItemGroup>
  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   .
   .
   .
    <Error Condition="!Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props'))" />
    <Error Condition="!Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets'))" />
  </Target>
  <Import Project="..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets" Condition="Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets')" />
  <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
       Other similar extension points exist, see Microsoft.Common.targets.
  <Target Name="BeforeBuild">
  </Target>
  <Target Name="AfterBuild">
  </Target>
  -->
</Project>

After migrate:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <ProjectGuid>{AC708E4D-2737-4D78-AA3D-2E42A48F4F51}</ProjectGuid>
    <RootNamespace>ProjectName</RootNamespace>
    <AssemblyName>ProjectName</AssemblyName>
    <TargetFramework>net471</TargetFramework>
    <SccProjectName>SAK</SccProjectName>
    <SccLocalPath>SAK</SccLocalPath>
    <SccAuxPath>SAK</SccAuxPath>
    <SccProvider>SAK</SccProvider>
    <AssemblyTitle>ClassLibrary1</AssemblyTitle>
    <Product>ClassLibrary1</Product>
    <Copyright>Copyright ©  2016</Copyright>
    <OutputPath>...............</OutputPath>
    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
  </PropertyGroup>
  <Import Project="..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props" Condition="Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props')" />
  <Import Project="..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets" Condition="Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets')" />
  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Error Condition="!Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.props'))" />
    <Error Condition="!Exists('..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Antlr4.CodeGenerator.4.6.5-rc002\build\Antlr4.CodeGenerator.targets'))" />
  </Target>
  <ItemGroup>
    <PackageReference Include="Antlr4" Version="4.6.5-rc002">
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Antlr4.CodeGenerator" Version="4.6.5-rc002">
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Antlr4.Runtime" Version="4.6.5-rc002" />
    .
    .
    .
  </ItemGroup>
  <ItemGroup>
    <Reference Include="Antlr4.Runtime, Version=4.6.0.0, Culture=neutral, PublicKeyToken=e9931a4108ef2354, processorArchitecture=MSIL">
      <HintPath>..\..\packages\Antlr4.Runtime.4.6.5-rc002\lib\net45\Antlr4.Runtime.dll</HintPath>
      <Private>True</Private>
    </Reference>
     .
     .
     .
  </ItemGroup>
   .
   .
   .
  <ItemGroup>
    <Compile Remove="obj.............................
  </ItemGroup>
</Project>

But this ItemGroup:

  <ItemGroup>
    <Antlr4 Include="filename1.g4">
      <Generator>MSBuild:Compile</Generator>
      <TargetLanguage>CSharp_v4_5</TargetLanguage>
      <CustomToolNamespace>myFramework</CustomToolNamespace>
    </Antlr4>
    <Antlr4 Include="filename2.g4">
      <Generator>MSBuild:Compile</Generator>
      <TargetLanguage>CSharp_v4_5</TargetLanguage>
      <CustomToolNamespace>myFramework</CustomToolNamespace>
    </Antlr4>
    <None Include="app.config" />
    <None Include="packages.config" />
  </ItemGroup>

Should be in csproj after the migration.
Without this lines:

    <None Include="app.config" />
    <None Include="packages.config" />

baruchiro · 2018-11-12T13:42:44Z

You can direct me and I will try to fix it myself.

hvanbakel · 2018-11-12T14:19:39Z

So it’s child nodes under ItemGroup, that should be straightforward. You should be able to add them here: CsprojToVs2017 <https://github.com/hvanbakel/CsprojToVs2017>/ Project2015To2017.Migrate2017.Library <https://github.com/hvanbakel/CsprojToVs2017/tree/master/Project2015To2017.Migrate2017.Library> /Transforms <https://github.com/hvanbakel/CsprojToVs2017/tree/master/Project2015To2017.Migrate2017.Library/Transforms> /FileTransformation.cs Under the items to always project.

…

On Mon, Nov 12, 2018 at 05:42 Baruch Rothkoff ***@***.***> wrote: You can direct me and I will try to fix it myself. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#208 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD8FPPBMEW6Jsg4pp6Xni2dtFjaZXyhgks5uuXrUgaJpZM4YYdLl> .

[Issue #208] Add Antlr4 tag support

hvanbakel · 2018-11-13T00:58:58Z

Merged, thanks for the PR. Publishing a new version now.

baruchiro · 2018-11-18T07:22:42Z

Antlr3 Add Antlr3 support #217

baruchiro mentioned this issue Nov 12, 2018

[Issue #208] Add Antlr4 tag support #209

Merged

hvanbakel added a commit that referenced this issue Nov 13, 2018

Merge pull request #209 from baruchiro/antlr4

f5f0dcc

[Issue #208] Add Antlr4 tag support

hvanbakel closed this as completed Nov 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Antlr4 syntax #208

Support Antlr4 syntax #208

baruchiro commented Nov 11, 2018

hvanbakel commented Nov 11, 2018 via email

baruchiro commented Nov 12, 2018

baruchiro commented Nov 12, 2018

hvanbakel commented Nov 12, 2018 via email

hvanbakel commented Nov 13, 2018

baruchiro commented Nov 18, 2018

Support Antlr4 syntax #208

Support Antlr4 syntax #208

Comments

baruchiro commented Nov 11, 2018

hvanbakel commented Nov 11, 2018 via email

baruchiro commented Nov 12, 2018

baruchiro commented Nov 12, 2018

hvanbakel commented Nov 12, 2018 via email

hvanbakel commented Nov 13, 2018

baruchiro commented Nov 18, 2018