Fix a couple small issues with the tlacli entrypoint and setup.py #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They are! Also man I should really figure out how to make tests for the parser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pydid not like that the file wasreadme.mdand notREADME.mdon my system. It was throwing an errorFileNotFoundError: [Errno 2] No such file or directory: 'README.md'. I don't know if that is a change in setuptools' behaviour or not, but it's a simple fix.Just running
tlacliwithout any arguments was throwing anAttributeErrorexception, so I wrapped it in a try/except and it now just prints the usage and exits if you call it without any arguments.Hope these are useful changes!