Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for FOSUser bundle #1732

Merged
merged 3 commits into from Aug 2, 2021
Merged

Remove support for FOSUser bundle #1732

merged 3 commits into from Aug 2, 2021

Conversation

stloyd
Copy link
Collaborator

@stloyd stloyd commented Jul 1, 2021

Fixes #1727

@stloyd stloyd force-pushed the feature/remove-fos branch 5 times, most recently from b86fbd0 to 4168201 Compare July 1, 2021 18:13
@stloyd stloyd requested a review from XWB July 1, 2021 18:14
@XWB XWB added this to the 2.0 - Game changer milestone Jul 1, 2021
@stloyd stloyd force-pushed the feature/remove-fos branch 10 times, most recently from 885cb06 to 4e29f04 Compare July 2, 2021 09:18
@stloyd
Copy link
Collaborator Author

stloyd commented Jul 2, 2021 •
edited

@XWB @stephanvierkant Finally green! :)

It does a bit more than expected:

  • removal of fos bundle,
  • all tests are running! This means we finally cover... connect feature!

@stloyd stloyd force-pushed the feature/remove-fos branch 3 times, most recently from 05096cb to 54627cf Compare July 5, 2021 15:47
dmaicher
dmaicher reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 👍

Controller/ConnectController.php Outdated Show resolved Hide resolved
Tests/Functional/Controller/ConnectControllerTest.php Outdated Show resolved Hide resolved
Tests/Functional/Controller/ConnectControllerTest.php Outdated Show resolved Hide resolved
@XWB XWB mentioned this pull request Jul 26, 2021
Closed
@stloyd stloyd force-pushed the feature/remove-fos branch 6 times, most recently from 150f63d to 5a61706 Compare July 27, 2021 07:47
@dmaicher
Copy link
Contributor

dmaicher commented Jul 27, 2021 •
edited

We can also clean-up the phpstan config then: https://github.com/hwi/HWIOAuthBundle/blob/master/phpstan.neon#L8

Edit: and also https://github.com/hwi/HWIOAuthBundle/blob/master/.github/workflows/ci.yaml#L145

@stloyd stloyd force-pushed the feature/remove-fos branch 3 times, most recently from 1d8ef79 to 6acc6d1 Compare July 29, 2021 07:27
dmaicher
dmaicher reviewed Jul 29, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@stloyd
Copy link
Collaborator Author

stloyd commented Jul 29, 2021

@XWB would be great to here your opinion about this, thanks! 🙃

@XWB
Copy link
Member

XWB commented Jul 29, 2021

I need some time to review, it's a big change. I will make some time in the coming days.

@XWB
Copy link
Member

XWB commented Aug 2, 2021

Seems good to me!

@stloyd stloyd merged commit 4b4ec05 into hwi:master Aug 2, 2021
@stloyd stloyd deleted the feature/remove-fos branch August 2, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@XWB XWB XWB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0 - Game changer
Development

Successfully merging this pull request may close these issues.

RFC | Remove support for FOSUser bundle
3 participants
@stloyd @dmaicher @XWB