Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FOSUserBundle from tests #1750

Closed
wants to merge 1 commit into from

Conversation

franmomu
Copy link
Contributor

On CI FOSUserBundle is always removed

- name: Remove FOSUser
run: composer remove friendsofsymfony/user-bundle --no-update --no-interaction --dev

and functional test are always skipped because of that.

@franmomu
Copy link
Contributor Author

locally I was getting:

<!-- The &quot;HWI\Bundle\OAuthBundle\Controller\ConnectController::getParameter()&quot; method is missing a parameter bag to work properly. Did you forget to register your controller as a service subscriber? This can be fixed either by using autoconfiguration or by manually wiring a &quot;parameter_bag&quot; in the service locator passed to the controller. (500 Internal Server Error) -->

I don't know why this annotation_reader error showed up 🤔

@XWB
Copy link
Member

XWB commented Jul 26, 2021

Please note that FOSUerBundle will be removed in #1732

@franmomu
Copy link
Contributor Author

franmomu commented Jul 26, 2021

Please note that FOSUerBundle will be removed in #1732

Yeah I know, the thing is that right now functional tests are being skipped from CI because we are removing FOSUserBundle in the CI pipeline and all functional tests are skipped if FOSUserBundle is not installed, so they are never executed.

My idea was to do this in 1.x so we can see the error that #1689 is trying to fix (it can be seen when installing the lowest version of packages), another approach would be to try to be able to execute these tests with FOSUserBundle installed.

@franmomu
Copy link
Contributor Author

Closed in favor of #1753

@franmomu franmomu closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants