Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility to matb33:collection-hooks #11

Closed
umbertooo opened this issue Oct 20, 2016 · 2 comments
Closed

Compatibility to matb33:collection-hooks #11

umbertooo opened this issue Oct 20, 2016 · 2 comments

Comments

@umbertooo
Copy link

Hi,
I try to use this package in project that makes heavy use of matb33:meteor-collection-hooks. I couldn't get the stubs-collections to work. Even when I copied your test code into the project (which, I suppose, sets up the StubCollections correctly ;) ) didn't work but reports:

AssertionError: expected 1 to equal 0
at Assertion.assertEqual (packages/practicalmeteor_chai.js?hash=5d06a5b89c39aede3a7f54e2ebfee2e82be547ff:1423:12)
at Assertion.ctx.(anonymous function) as equal
at Context. (packages/local-test_hwillson_stub-collections.js?hash=6d76189a9c590d6ed651e0c5dfcd9486279f5c8c:75:39)
at callFn (packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4345:21)
at Test.Runnable.run (packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4338:7)
at Runner.runTest (packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4808:10)
at packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4919:12
at next (packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4728:14)
at packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4738:7
at next (packages/practicalmeteor_mocha-core.js?hash=12c98471b374d75331cd9dcc7e691e23967c4550:4670:14)

I tried deactivating the installed packages and found out that these collection hooks are the problem. It looks like the collection hooks create some wrappers, StubCollections doesn't recognize... I forked your repo and added them to the test environment: umbertooo@33843c5

hwillson added a commit that referenced this issue Nov 15, 2016
Retrieve all property names of Collection, fixes #11
@hwillson
Copy link
Owner

Thanks for reporting this @umbertooo - @davidyuk has submitted a PR to fix this, which I've merged and will get published soon.

@hwillson
Copy link
Owner

1.0.3 has been published - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants