Add more stubs for Meteor CollectionHooks cols #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionHooks builds Collections with a hijacked constructor. They "take over" most collection methods, but StubCollections will stub them... no problem (before this commit). Though Collectionhooks would make a `direct` object and allow access to the "pre-hooked" (normal) methods for the Collection. Until this commit, that meant that all "Stubbed" collections worked as a "stub" for normal methods like `MyCol.update()`, but would use their "non-stubbed/real" methods when used like `MyCol.direct.update()` Now we are "stubbing" both set's of methods. TODO: It would be really nice if we could make Collectionhooks still run it's functionality on the stubbed collection :/ -- I have not been able to figure out how to accomplish this yet.
|
Any feedback on this? |
|
Wow, sorry for the large delay on this @zeroasterisk - I'll definitely get this reviewed shortly. Thanks! |
|
Thanks for submitting this @zeroasterisk - this all makes sense, and looks good. I'm prepping a new release for tomorrow, and will get this merged in shortly. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectionHooks builds Collections with a hijacked constructor.
They "take over" most collection methods,
but StubCollections will stub them... no problem (before this commit).
Though Collectionhooks would make a
directobject and allow access tothe "pre-hooked" (normal) methods for the Collection.
Until this commit, that meant that all "Stubbed" collections
worked as a "stub" for normal methods like
MyCol.update(),but would use their "non-stubbed/real" methods when used like
MyCol.direct.update()Now we are "stubbing" both set's of methods.
TODO: It would be really nice if we could make Collectionhooks still run
it's functionality on the stubbed collection :/ -- I have not been able
to figure out how to accomplish this yet.
re #11 (again)