Added Yandex provider #1016
Merged
Added Yandex provider #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ApacheEx
requested changes
Dec 1, 2018
src/Provider/Yandex.php
Outdated
| { | ||
| $data = parent::validateAccessTokenExchange($response); | ||
|
|
||
| // Need to store user_id as token for later use. |
There was a problem hiding this comment.
do not see any usages of this. Why do we need to overried this method?
src/Provider/Yandex.php
Outdated
|
|
||
| return $userProfile; | ||
| } | ||
| } |
src/Provider/Yandex.php
Outdated
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function hasAccessTokenExpired() |
There was a problem hiding this comment.
do not see reason to override this method - the same logic as in parent class.
|
@ApacheEx added changes, tested new changes and it still works as expected 👍 |
|
@ApacheEx could you please review and merge? |
ApacheEx
approved these changes
Jan 2, 2019
|
Thanks a lot. Great job 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Yandex provider for v3 for #1013