Wrap Stdio write in some tests and do a little cleanup. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using dependency injection was the only way I could see to make write testable. Interface defaults to InterfaceHelper.new.get_interface
kiafaldorius
pushed a commit
that referenced
this pull request
May 17, 2011
Wrap Stdio write in some tests and do a little cleanup.
|
Merged. Thanks! |
|
Woot! Nice commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another one. This doesn't (shouldn't?) change any functionality. Just adds some tests and a) refactors KidsRubyStdIo to make it testable and b) dries it up a little. I left the individual commits in both of these pull requests so you see the steps I took.
How's it look?
I can't do manual tests yet. Even though KidsRuby loads fine, I don't see any output.