test: update setup, cover useForm's isDirty
#116
Conversation
….getReader method on responses
…can be invoked for specific tests that need the mock server
❌ Deploy Preview for hybridly failed.
|
| beforeEach(() => { | ||
| fakeRouterContext() | ||
| beforeEach(async() => { | ||
| await fakeRouterContext() |
There was a problem hiding this comment.
Ensuring we wait for the context to be set up before starting the tests
| import { fakeRouterContext, fakePayload, mockSuccessfulUrl } from '../utils' | ||
| import { createServer } from '../server' | ||
|
|
||
| const server = createServer() |
There was a problem hiding this comment.
I've removed the setup.ts file that was used to set up the server in all of the tests. I was running into some sort of async state issue when running the entire test suite, which now has multiple calls to the mock server.
This fix of creating the server per test file seemed to fix the issue, and should also mean we don't create the server for tests that won't use it.
| beforeEach(() => { | ||
| fakeRouterContext() | ||
| vi.stubGlobal('console', { | ||
| warn: vi.fn(), |
There was a problem hiding this comment.
These mocked functions were hiding an error that was being thrown during the request to the mocked server that said that there was no handler defined for the given request.
To define the handlers, you must either pass them in when calling setupServer, or you can call resetHandlers() and pass them in to an existing server.
| @@ -27,8 +26,7 @@ export function makeRouterContextOptions(options: PartialDeep<RouterContextOptio | |||
| payload: fakePayload(), | |||
| adapter: { | |||
| resolveComponent: noop, | |||
| swapDialog: noop, | |||
| swapView: noop, | |||
| onViewSwap: noop, | |||
There was a problem hiding this comment.
swapDialog and swapView no longer exist, replaced with onViewSwap
|
So I'm running into an issue running the tests locally. Only on the first run after installing the dependencies, the tests fail. If I immediately re-run the tests, then they pass. The issue is that the |
innocenzi
changed the title
useForm's isDirty
| @@ -1,5 +1,5 @@ | |||
| export { createRouter, router } from './router' | |||
| export type { Router, HybridRequestOptions, NavigationResponse, HybridPayload, ResolveComponent, Method, Progress } from './router' | |||
| export { createRouter, router } from './router/router' | |||
There was a problem hiding this comment.
This fixed an issue I was having where the tests would fail on the first run after installing the dependencies.
There was a problem hiding this comment.
That's interesting, do you know why this specifically caused the issue?
There was a problem hiding this comment.
Not sure. I had found some Google results about needing to import * as x but that only applies to default exports, could be a phantom fix.
innocenzi
force-pushed
the
use-form-tests
branch
from
a7e2029
to
9d0ebc1
Compare
|
That's awesome. Thanks a lot Owen! |
This PR introduces a new test class for testing the
formcomposable, specifically just theisDirtyref for now.While trying to add this test class, I ran into a few errors with how the tests have been configured. The root of the problem lies within the
happy-dompackage, issue here: capricorn86/happy-dom#1180. Essentially,happy-domdoes not implement the Request/Response classes like the browser does.mswrelies on the browser's implementation when mocking requests.To get around this issue for now, I've downgraded
vitestto 0.34.6. However, this only fixed the issue locally for me. When running in CI, I was getting the same error. It turns out that in addition to downgradingvitest, I also had to update Node to v18 from v16. Hopefully that isn't a big deal.I've gone through the diff and left comments on the individual pieces with reasons for each change.