Merge pull request #1555 from hydephp/code-cleanup

Clean up code
hydephp · Feb 12, 2024 · 31dbd8a · 31dbd8a
2 parents 7676ac9 + 0501e8f
commit 31dbd8a
Show file tree

Hide file tree

Showing 14 changed files with 27 additions and 3 deletions.
diff --git a/.idea/php.xml b/.idea/php.xml
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -29,6 +29,7 @@ This serves two purposes:
 - Renamed local template variable `$document` to `$article` to better match the usage in https://github.com/hydephp/develop/pull/1506
 - Updated semantic documentation article component to support existing variables in https://github.com/hydephp/develop/pull/1506
 - HydeFront: Changed `<code>` styling to display as inline instead of inline-block in https://github.com/hydephp/develop/pull/1525
+- Realtime Compiler: Add strict type declarations in https://github.com/hydephp/develop/pull/1555/files
 
 ### Deprecated
 - Deprecated the `BuildService::transferMediaAssets()` method in https://github.com/hydephp/develop/pull/1533, as it will be moved into a build task in v2.0.

diff --git a/packages/framework/src/Console/Commands/ServeCommand.php b/packages/framework/src/Console/Commands/ServeCommand.php
@@ -14,6 +14,7 @@
 use Illuminate\Support\Facades\Process;
 
 use function sprintf;
+use function in_array;
 use function str_replace;
 use function class_exists;
 

diff --git a/packages/framework/src/Facades/Config.php b/packages/framework/src/Facades/Config.php
@@ -7,6 +7,7 @@
 use TypeError;
 
 use function sprintf;
+use function gettype;
 use function call_user_func;
 
 /**

diff --git a/packages/publications/src/Concerns/PublicationFieldTypes.php b/packages/publications/src/Concerns/PublicationFieldTypes.php
@@ -72,7 +72,7 @@ public static function getRules(self $type): array
     /**
      * The types that can be used for canonical fields (used to generate file names).
      *
-     * @return \Hyde\Publications\PublicationFieldTypes[]
+     * @return \Hyde\Publications\Concerns\PublicationFieldTypes[]
      */
     public static function canonicable(): array
     {
@@ -87,7 +87,7 @@ public static function canonicable(): array
     /**
      * The types that can be array values.
      *
-     * @return \Hyde\Publications\PublicationFieldTypes[]
+     * @return \Hyde\Publications\Concerns\PublicationFieldTypes[]
      */
     public static function arrayable(): array
     {

diff --git a/packages/realtime-compiler/src/Actions/AssetFileLocator.php b/packages/realtime-compiler/src/Actions/AssetFileLocator.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Actions;
 
 /**

diff --git a/packages/realtime-compiler/src/Concerns/InteractsWithLaravel.php b/packages/realtime-compiler/src/Concerns/InteractsWithLaravel.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Concerns;
 
 use Illuminate\Contracts\Console\Kernel;

diff --git a/packages/realtime-compiler/src/Concerns/SendsErrorResponses.php b/packages/realtime-compiler/src/Concerns/SendsErrorResponses.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Concerns;
 
 use Desilva\Microserve\Response;

diff --git a/packages/realtime-compiler/src/Http/ExceptionHandler.php b/packages/realtime-compiler/src/Http/ExceptionHandler.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Http;
 
 use Desilva\Microserve\Response;

diff --git a/packages/realtime-compiler/src/Http/HtmlResponse.php b/packages/realtime-compiler/src/Http/HtmlResponse.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Http;
 
 use Desilva\Microserve\Response;

diff --git a/packages/realtime-compiler/src/Http/HttpKernel.php b/packages/realtime-compiler/src/Http/HttpKernel.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Http;
 
 use Desilva\Microserve\HttpKernel as BaseHttpKernel;

diff --git a/packages/realtime-compiler/src/Models/FileObject.php b/packages/realtime-compiler/src/Models/FileObject.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Models;
 
 /**

diff --git a/packages/realtime-compiler/src/Routing/PageRouter.php b/packages/realtime-compiler/src/Routing/PageRouter.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Routing;
 
 use Desilva\Microserve\Request;

diff --git a/packages/realtime-compiler/src/Routing/Router.php b/packages/realtime-compiler/src/Routing/Router.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Hyde\RealtimeCompiler\Routing;
 
 use Desilva\Microserve\JsonResponse;