Merge pull request #1607 from hydephp/refactor-test-internals

Internal: Move testing helper classes to new helpers directory
hydephp · Mar 13, 2024 · 9a2ed40 · 9a2ed40
2 parents 79a62e0 + 8d4ffc7
commit 9a2ed40
Show file tree

Hide file tree

Showing 9 changed files with 49 additions and 40 deletions.
diff --git a/packages/framework/tests/Unit/Pages/BladePageUnitTest.php b/packages/framework/tests/Unit/Pages/BladePageUnitTest.php
@@ -4,15 +4,16 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
-use Hyde\Foundation\Kernel\PageCollection;
-use Hyde\Framework\Factories\Concerns\CoreDataObject;
-use Hyde\Framework\Features\Metadata\PageMetadataBag;
 use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Pages\BladePage;
 use Hyde\Support\Models\Route;
+use Hyde\Markdown\Models\FrontMatter;
+use Hyde\Foundation\Kernel\PageCollection;
+use Hyde\Framework\Factories\Concerns\CoreDataObject;
+use Hyde\Framework\Features\Metadata\PageMetadataBag;
+use Hyde\Framework\Testing\helpers\BaseHydePageUnitTest;
 
-require_once __DIR__.'/BaseHydePageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseHydePageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\BladePage

diff --git a/packages/framework/tests/Unit/Pages/DocumentationPageUnitTest.php b/packages/framework/tests/Unit/Pages/DocumentationPageUnitTest.php
@@ -4,17 +4,18 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
+use Hyde\Hyde;
 use Hyde\Facades\Filesystem;
+use Hyde\Support\Models\Route;
+use Hyde\Pages\DocumentationPage;
+use Hyde\Markdown\Models\Markdown;
+use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Foundation\Kernel\PageCollection;
 use Hyde\Framework\Factories\Concerns\CoreDataObject;
 use Hyde\Framework\Features\Metadata\PageMetadataBag;
-use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
-use Hyde\Markdown\Models\Markdown;
-use Hyde\Pages\DocumentationPage;
-use Hyde\Support\Models\Route;
+use Hyde\Framework\Testing\helpers\BaseMarkdownPageUnitTest;
 
-require_once __DIR__.'/BaseMarkdownPageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseMarkdownPageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\DocumentationPage

diff --git a/packages/framework/tests/Unit/Pages/HtmlPageUnitTest.php b/packages/framework/tests/Unit/Pages/HtmlPageUnitTest.php
@@ -4,15 +4,16 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
-use Hyde\Foundation\Kernel\PageCollection;
-use Hyde\Framework\Factories\Concerns\CoreDataObject;
-use Hyde\Framework\Features\Metadata\PageMetadataBag;
 use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Pages\HtmlPage;
 use Hyde\Support\Models\Route;
+use Hyde\Markdown\Models\FrontMatter;
+use Hyde\Foundation\Kernel\PageCollection;
+use Hyde\Framework\Factories\Concerns\CoreDataObject;
+use Hyde\Framework\Features\Metadata\PageMetadataBag;
+use Hyde\Framework\Testing\helpers\BaseHydePageUnitTest;
 
-require_once __DIR__.'/BaseHydePageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseHydePageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\HtmlPage

diff --git a/packages/framework/tests/Unit/Pages/InMemoryPageUnitTest.php b/packages/framework/tests/Unit/Pages/InMemoryPageUnitTest.php
@@ -4,16 +4,17 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
+use Hyde\Hyde;
+use Hyde\Pages\InMemoryPage;
+use Hyde\Support\Models\Route;
 use Hyde\Foundation\HydeKernel;
+use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Foundation\Kernel\PageCollection;
 use Hyde\Framework\Factories\Concerns\CoreDataObject;
 use Hyde\Framework\Features\Metadata\PageMetadataBag;
-use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
-use Hyde\Pages\InMemoryPage;
-use Hyde\Support\Models\Route;
+use Hyde\Framework\Testing\helpers\BaseHydePageUnitTest;
 
-require_once __DIR__.'/BaseHydePageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseHydePageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\InMemoryPage

diff --git a/packages/framework/tests/Unit/Pages/MarkdownPageUnitTest.php b/packages/framework/tests/Unit/Pages/MarkdownPageUnitTest.php
@@ -4,17 +4,18 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
+use Hyde\Hyde;
 use Hyde\Facades\Filesystem;
+use Hyde\Pages\MarkdownPage;
+use Hyde\Support\Models\Route;
+use Hyde\Markdown\Models\Markdown;
+use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Foundation\Kernel\PageCollection;
 use Hyde\Framework\Factories\Concerns\CoreDataObject;
 use Hyde\Framework\Features\Metadata\PageMetadataBag;
-use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
-use Hyde\Markdown\Models\Markdown;
-use Hyde\Pages\MarkdownPage;
-use Hyde\Support\Models\Route;
+use Hyde\Framework\Testing\helpers\BaseMarkdownPageUnitTest;
 
-require_once __DIR__.'/BaseMarkdownPageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseMarkdownPageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\MarkdownPage

diff --git a/packages/framework/tests/Unit/Pages/MarkdownPostUnitTest.php b/packages/framework/tests/Unit/Pages/MarkdownPostUnitTest.php
@@ -4,17 +4,18 @@
 
 namespace Hyde\Framework\Testing\Unit\Pages;
 
+use Hyde\Hyde;
 use Hyde\Facades\Filesystem;
+use Hyde\Pages\MarkdownPost;
+use Hyde\Support\Models\Route;
+use Hyde\Markdown\Models\Markdown;
+use Hyde\Markdown\Models\FrontMatter;
 use Hyde\Foundation\Kernel\PageCollection;
 use Hyde\Framework\Factories\Concerns\CoreDataObject;
 use Hyde\Framework\Features\Metadata\PageMetadataBag;
-use Hyde\Hyde;
-use Hyde\Markdown\Models\FrontMatter;
-use Hyde\Markdown\Models\Markdown;
-use Hyde\Pages\MarkdownPost;
-use Hyde\Support\Models\Route;
+use Hyde\Framework\Testing\helpers\BaseMarkdownPageUnitTest;
 
-require_once __DIR__.'/BaseMarkdownPageUnitTest.php';
+require_once __DIR__.'/../../helpers/BaseMarkdownPageUnitTest.php';
 
 /**
  * @covers \Hyde\Pages\MarkdownPost

diff --git a/...tests/Unit/Pages/BaseHydePageUnitTest.php → ...rk/tests/helpers/BaseHydePageUnitTest.php b/...tests/Unit/Pages/BaseHydePageUnitTest.php → ...rk/tests/helpers/BaseHydePageUnitTest.php
@@ -2,15 +2,15 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Unit\Pages;
+namespace Hyde\Framework\Testing\helpers;
 
+use Mockery;
+use Illuminate\View\Factory;
+use Hyde\Testing\UnitTestCase;
 use Hyde\Support\Facades\Render;
 use Hyde\Support\Models\RenderData;
-use Hyde\Testing\CreatesTemporaryFiles;
-use Hyde\Testing\UnitTestCase;
 use Illuminate\Support\Facades\View;
-use Illuminate\View\Factory;
-use Mockery;
+use Hyde\Testing\CreatesTemporaryFiles;
 
 /**
  * Providers helpers and a contract for unit testing for the specified page class.

diff --git a/...s/Unit/Pages/BaseMarkdownPageUnitTest.php → ...ests/helpers/BaseMarkdownPageUnitTest.php b/...s/Unit/Pages/BaseMarkdownPageUnitTest.php → ...ests/helpers/BaseMarkdownPageUnitTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Unit\Pages;
+namespace Hyde\Framework\Testing\helpers;
 
 require_once __DIR__.'/BaseHydePageUnitTest.php';
 
@@ -11,7 +11,7 @@
  *
  * These unit tests ensure all inherited methods are callable, and that they return the expected value.
  *
- * @see \Hyde\Framework\Testing\Unit\Pages\BaseHydePageUnitTest
+ * @see \Hyde\Framework\Testing\helpers\BaseHydePageUnitTest
  *
  * @coversNothing
  */

diff --git a/packages/framework/tests/helpers/README.md b/packages/framework/tests/helpers/README.md
@@ -0,0 +1,3 @@
+# Internal testing helpers
+
+This directory contains a set of internal testing helpers that are included directly by some tests.