Merge pull request #1399 from hydephp/general-bugfixes

Use a custom exception message when failing to get image size

RELEASE_NOTES.md

@@ -30,6 +30,7 @@ This serves two purposes:
 - Updated dropdown navigation menus to support setting priority in config in https://github.com/hydephp/develop/pull/1387 (fixing https://github.com/hydephp/hyde/issues/229)
 - Updated the vendor publish command to support parent Laravel Prompts implementation in https://github.com/hydephp/develop/pull/1388
 - Fixed wrong version constant in https://github.com/hydephp/develop/pull/1391
+- Fixed improperly formatted exception message in https://github.com/hydephp/develop/pull/1399
 
 ### Security
 - in case of vulnerabilities.

packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php

@@ -217,7 +217,7 @@ protected function getContentLengthForLocalImage(): int
         $storagePath = Hyde::mediaPath($this->source);
 
         if (! file_exists($storagePath)) {
-            throw new FileNotFoundException(sprintf('Image at %s does not exist', Hyde::pathToRelative($storagePath)));
+            throw new FileNotFoundException(customMessage: sprintf('Featured image [%s] not found.', Hyde::pathToRelative($storagePath)));
         }
 
         return filesize($storagePath);

packages/framework/tests/Unit/FeaturedImageUnitTest.php

@@ -124,7 +124,7 @@ public function testGetContentLength()
     public function testFeaturedImageGetContentLengthWithNoSource()
     {
         $this->expectException(FileNotFoundException::class);
-        $this->expectExceptionMessage('Image at _media/foo does not exist');
+        $this->expectExceptionMessage('Featured image [_media/foo] not found.');
 
         $image = new FeaturedImage('_media/foo', ...$this->defaultArguments());
         $this->assertEquals(0, $image->getContentLength());