Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Simplified featured image schema for blog posts #1718

Open
Tracked by #1499
caendesilva opened this issue Jun 8, 2024 · 1 comment
Open
Tracked by #1499

[2.x] Simplified featured image schema for blog posts #1718

caendesilva opened this issue Jun 8, 2024 · 1 comment

Comments

@caendesilva
Copy link
Member

caendesilva commented Jun 8, 2024

Okay, I'm gonna be honest here. I in theory love that HydePHP can assemble dynamic featured image captions. But in practise, it doesn't work. I wrote the code and designed the schema, and I still can never remember what the accepted properties are. I think for v2, it's worth the BC break to simplify these. Stuff like altText and licenseUrl is just too hard to remember.

Instead, this would be much better, to have a literal caption field instead of dynamic data items:

image:
    source: how-to-turn-your-github-readme-into-a-static-website-cropped.png
    alt: Example of a static website created from a GitHub Readme
    caption: Static website from GitHub Readme

If alt text is not set, but caption is, then we can use the caption as the alt.

If we wanted to have fun, we can have a migration script that converts the old files into the new format by assembling the fields according to the v1 rules.

caendesilva added a commit to hydephp/hydephp.com that referenced this issue Jun 8, 2024
@caendesilva
Copy link
Member Author

We may consider backporting support for the new syntax to 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant