Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RouteKey normalization for dot notation support #1241

Merged

Conversation

caendesilva
Copy link
Member

Fixes #1240

@caendesilva caendesilva linked an issue Mar 8, 2023 that may be closed by this pull request
@caendesilva caendesilva temporarily deployed to pr-documentation-1241 March 8, 2023 12:05 — with GitHub Actions Inactive
@caendesilva caendesilva marked this pull request as ready for review March 8, 2023 12:06
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1241 (6a46bda) into master (cfac85d) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1241     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1317      2634   +1317     
=============================================
  Files            152       304    +152     
  Lines           3459      6918   +3459     
=============================================
+ Hits            3459      6918   +3459     
Impacted Files Coverage Δ
packages/framework/src/Support/Models/RouteKey.php 100.00% <100.00%> (ø)
...ramework/Actions/PostBuildTasks/GenerateSearch.php 100.00% <0.00%> (ø)
develop/packages/framework/src/Facades/Author.php 100.00% <0.00%> (ø)
...ackages/framework/src/Foundation/Facades/Pages.php 100.00% <0.00%> (ø)
...work/src/Framework/Features/Navigation/NavItem.php 100.00% <0.00%> (ø)
...amework/src/Framework/Services/MarkdownService.php 100.00% <0.00%> (ø)
.../Framework/Features/Blogging/Models/PostAuthor.php 100.00% <0.00%> (ø)
...ork/src/Console/Commands/PublishConfigsCommand.php 100.00% <0.00%> (ø)
...lop/packages/framework/src/Support/ReadingTime.php 100.00% <0.00%> (ø)
...c/Framework/Actions/ConvertsArrayToFrontMatter.php 100.00% <0.00%> (ø)
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…ion' of github.com:hydephp/develop into remove-support-for-dot-notation-in-route-key-normalization
@caendesilva caendesilva merged commit 37fb7a0 into master Mar 8, 2023
@caendesilva caendesilva deleted the remove-support-for-dot-notation-in-route-key-normalization branch March 8, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for dot notation in route key normalization
2 participants