Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source file creator actions #1393

Merged
merged 19 commits into from Oct 21, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Oct 21, 2023

Main features:

  • Allows custom content to be added when calling the source file creator actions directly.
  • Allows custom date to be setwhen calling the post creator action directly.
  • Updates the post creator action to use a mockable time helper from Illuminate\Carbon to improve testing

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1393 (3454d57) into master (0dd4cf1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             master    #1393     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1698     3402   +1704     
===========================================
  Files           180      360    +180     
  Lines          4600     9218   +4618     
===========================================
+ Hits           4599     9216   +4617     
- Misses            1        2      +1     
Files Coverage Δ
...c/Framework/Actions/CreatesNewMarkdownPostFile.php 100.00% <100.00%> (ø)
...src/Framework/Actions/CreatesNewPageSourceFile.php 100.00% <100.00%> (ø)

... and 180 files with indirect coverage changes

@caendesilva caendesilva force-pushed the improve-source-file-creator-actions branch from 3cbf0f7 to 28713cb Compare October 21, 2023 15:01
@caendesilva caendesilva force-pushed the improve-source-file-creator-actions branch from 5c9d35b to 12db0fc Compare October 21, 2023 15:11
@caendesilva caendesilva marked this pull request as ready for review October 21, 2023 15:28
@caendesilva caendesilva merged commit 2726876 into master Oct 21, 2023
19 checks passed
@caendesilva caendesilva deleted the improve-source-file-creator-actions branch October 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants