Update configuration option for the documentation sidebar footer to allow custom Markdown to be specified #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1477 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1730 3460 +1730
=============================================
Files 180 360 +180
Lines 4695 9390 +4695
=============================================
+ Hits 4695 9390 +4695 ☔ View full report in Codecov by Sentry. |
caendesilva
deleted the
documentation-sidebar-footer-configuration-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474 by checking if the existing
docs.sidebar.footeroption is a string, and if so it replaces the default "Back to home" link with that content. Like before, if the option isfalsethe footer is not rendered at all.