Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Honour front matter navigation groups set in front matter regardless of subdirectory setting #1703

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Apr 29, 2024

This pull request fixes #1515, which concerns the inconsistency in navigation group behavior when setting navigation groups for standard pages in front matter alongside the dropdown subdirectory setting in the configuration file.

Using the following in _pages/page.md will now cause the page to be put in the appropriate dropdown regardless of the hyde.navigation.subdirectories setting. This better follows the principle of least astonishment as setting the front matter is an explicit instruction to HydePHP.

---
navigation.group: My Group
---

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (f094c1b) to head (37d0ccb).
Report is 1 commits behind head on master.

❗ Current head 37d0ccb differs from pull request most recent head ee7e8a6. Consider uploading reports for the commit ee7e8a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1703   +/-   ##
=========================================
  Coverage     99.97%   99.97%           
- Complexity     1742     1745    +3     
=========================================
  Files           181      181           
  Lines          4657     4661    +4     
=========================================
+ Hits           4656     4660    +4     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the enable-dropdowns-when-set-in-front-matter-regardless-of-subdirectory-configuration branch 2 times, most recently from 72bec82 to 4884ea5 Compare April 29, 2024 19:54
@caendesilva caendesilva force-pushed the enable-dropdowns-when-set-in-front-matter-regardless-of-subdirectory-configuration branch from 4884ea5 to 917dcb3 Compare April 29, 2024 19:55
@caendesilva caendesilva marked this pull request as ready for review April 30, 2024 07:51
@caendesilva caendesilva merged commit 3d2d696 into master Apr 30, 2024
20 checks passed
@caendesilva caendesilva deleted the enable-dropdowns-when-set-in-front-matter-regardless-of-subdirectory-configuration branch April 30, 2024 07:51
@caendesilva caendesilva changed the title Honour front matter navigation groups set in front matter regardless of subdirectory setting [1.x] Honour front matter navigation groups set in front matter regardless of subdirectory setting Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant