[2.x] Improve the numerical filename priority prefix feature #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1710 +/- ##
==========================================
Coverage 99.97% 99.97%
- Complexity 1784 1787 +3
==========================================
Files 184 184
Lines 4738 4748 +10
==========================================
+ Hits 4737 4747 +10
Misses 1 1 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
support-automatic-navigation-priorities-by-prefixing-a-number-in-filenames
branch
from
26ec193
to
1babead
Compare
caendesilva
force-pushed
the
support-automatic-navigation-priorities-by-prefixing-a-number-in-filenames
branch
from
5689ead
to
2f8de3f
Compare
Want to use dynamic datasets
This reverts commit 0a7e8fb.
Didn't realize this could also run multiple tests like in Pest
caendesilva
force-pushed
the
support-automatic-navigation-priorities-by-prefixing-a-number-in-filenames
branch
3 times, most recently
from
b5456e1
to
ed92c8e
Compare
caendesilva
force-pushed
the
support-automatic-navigation-priorities-by-prefixing-a-number-in-filenames
branch
from
9dadbd1
to
7363134
Compare
Renames isIdentifierNumbered to hasNumericalPrefix
Renames splitNumberAndIdentifier to splitNumericPrefix
I think delimiter is better than divider here
In case we want to customize this later it's easier to see here
Based on the navigation data factory unit tests, but to test the ancillary extraction
caendesilva
commented
May 7, 2024
caendesilva
changed the title
caendesilva
deleted the
support-automatic-navigation-priorities-by-prefixing-a-number-in-filenames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors some code introduced in #1709 and implements the remaining documented tasks and adds a lot more tests as this is an important feature that is implemented through several interconnected parts of the codebase, thus unit tests are added to make sure the code units operate as expected; as mainly high level feature tests were added in the original PR.