Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure service providers #977

Merged
merged 8 commits into from Feb 12, 2023
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 11, 2023

Abstract

Further restructures the Hyde service providers so each one has their own scoped function. See #939

Main changes

  1. Register providers in the app.php config instead of through the HydeServiceProvider
    - This allows them to be swapped out by advanced end users
  2. Renames HydeConsoleServiceProvider to ConsoleServiceProvider
    - This is because no other providers have such a prefix, nor is it warranted
  3. Normalize service provider code style and presentation
    - This is purely cosmetic

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #977 (fda35fe) into master (1230fef) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #977     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1265      2528   +1263     
=============================================
  Files            150       300    +150     
  Lines           3337      6664   +3327     
=============================================
+ Hits            3337      6664   +3327     
Impacted Files Coverage Δ
...k/src/Foundation/Providers/ViewServiceProvider.php 100.00% <ø> (ø)
...es/framework/src/Framework/HydeServiceProvider.php 100.00% <ø> (ø)
...s/framework/src/Console/ConsoleServiceProvider.php 100.00% <100.00%> (ø)
...rc/Framework/Factories/Concerns/CoreDataObject.php 100.00% <0.00%> (ø)
...es/framework/src/Support/Concerns/Serializable.php 100.00% <0.00%> (ø)
...c/Foundation/Concerns/BaseFoundationCollection.php 100.00% <0.00%> (ø)
...ages/framework/src/Markdown/Models/FrontMatter.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/PackageDiscoverCommand.php 100.00% <0.00%> (ø)
...elop/packages/framework/src/Facades/Filesystem.php 100.00% <0.00%> (ø)
...work/src/Framework/Concerns/ValidatesExistence.php 100.00% <0.00%> (ø)
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 12, 2023 09:00
@caendesilva caendesilva merged commit ada723c into master Feb 12, 2023
@caendesilva caendesilva deleted the restructure-service-providers branch February 12, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant