Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with --prefer-lowest in test suite #93

Closed
caendesilva opened this issue Apr 9, 2022 · 4 comments
Closed

Fix compatibility with --prefer-lowest in test suite #93

caendesilva opened this issue Apr 9, 2022 · 4 comments

Comments

@caendesilva
Copy link
Member

Tests running on with composer --prefer-lowest are failing. Raising this issue to investigate.

@caendesilva
Copy link
Member Author

Root cause for all four fails is Call to undefined method Illuminate\Testing\PendingCommand::expectsOutputToContain()

@caendesilva
Copy link
Member Author

Illuminate\Testing\PendingCommand::expectsOutputToContain() was added inhttps://github.com/laravel/framework/pull/40984 an released in https://github.com/laravel/framework/releases/tag/v9.2.0, but laravel-zero https://github.com/laravel-zero/laravel-zero/blob/master/composer.json requires minimum v9.0.0.

@caendesilva
Copy link
Member Author

Confirmed the file used when running the latest versions is vendor\illuminate\testing\PendingCommand.php, am so far unable to include it when setting minimum to 9.2.

@caendesilva
Copy link
Member Author

Since Hyde is not a traditional package in the sense it needs to be compatible with existing installations as it is a framework on its own I will close this and remove the --prefer-lowest in the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant