Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with errors in function values crashing hydra #17

Merged
merged 1 commit into from
Jun 30, 2019

Conversation

rumblesan
Copy link
Contributor

So I had a quick look into issue https://github.com/ojack/hydra/issues/51 on the hydra repo that @zachkrall tagged me in.
As best I can tell, the problem is that whilst all the javascript that gets evaluated is within a try/catch block, any functions passed in as arguments don't get run within this and so errors won't get caught.

I think this change will fix it by adding try/catch statements around the functions when they're run, but I'm not actually able to build hydra-synth for some reason and so don't know yet 😅

I'll see about having another go later today, but thought I'd throw this up here now.

@ojack
Copy link
Member

ojack commented Jun 30, 2019

yes! this fixes it. (i do dev by running 'npm run example' and it automatically builds.) need a better way of logging this error to the user in the editor version, i am going to open another issue for that.

@ojack ojack merged commit 813a96f into hydra-synth:master Jun 30, 2019
@rumblesan rumblesan deleted the value-function-fix branch June 30, 2019 18:17
@rumblesan
Copy link
Contributor Author

so when I run npm run example I'm getting the server running, but then when I browse to the page I'm getting an error
Cannot find module 'webrtc-adapter'

Glad that this fixes the issue though. I've been meaning to get back digging into the synth, but there's only so many hours in the day hah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants