Fix issue with errors in function values crashing hydra #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I had a quick look into issue https://github.com/ojack/hydra/issues/51 on the hydra repo that @zachkrall tagged me in.
As best I can tell, the problem is that whilst all the javascript that gets evaluated is within a try/catch block, any functions passed in as arguments don't get run within this and so errors won't get caught.
I think this change will fix it by adding try/catch statements around the functions when they're run, but I'm not actually able to build hydra-synth for some reason and so don't know yet 😅
I'll see about having another go later today, but thought I'd throw this up here now.