Switch to use defusedxml as the default xml loader. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njoyce
force-pushed
the
defusedxml
branch
2 times, most recently
from
49b9345
to
29b5ed0
Compare
By default, PyAMF will not support potentially vulnerable payloads. See https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing. All the standard XML processing libs that PyAMF previously supported are still supported. There may be people who use DTD/Entities as part of their AMF payloads - they will have to continue to use an old version or make an issue to see how their use case can still be supported.
njoyce
added a commit
that referenced
this pull request
Dec 17, 2015
Switch to use defusedxml as the default xml loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, PyAMF will not support potentially vulnerable XML payloads. See
https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing.
Wrap all calls to
etree.fromstring()withdefusedxml. All the standard XML processing libs that PyAMF previously supported are still supported.There may be people who use DTD/Entities as part of their AMF payloads - they will have
to continue to use an old version or make an issue to see how their use case can still be
supported.