Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Catalan translation. #605

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Added Catalan translation. #605

merged 8 commits into from
Jun 27, 2024

Conversation

Ecron
Copy link
Contributor

@Ecron Ecron commented Jun 18, 2024

Added Catalan translation.

Added Catalan translation.
@zamitto
Copy link
Collaborator

zamitto commented Jun 19, 2024

You need to also export your language in the src/locales/index.ts file

@Ecron
Copy link
Contributor Author

Ecron commented Jun 20, 2024

You need to also export your language in the src/locales/index.ts file

Sorry, totally forgot. Done now 👍 Thanks!

@zamitto
Copy link
Collaborator

zamitto commented Jun 20, 2024

I just added two comments with things that a could remember now. Other than that LGTM.
If you are insterested in keeping this language updated, you can join our Telegram. We ask for help in the Translators channel when there is new text to translate

Removed social networks.
Removed the splash section.
Added 2 new strings under header section.
@Ecron
Copy link
Contributor Author

Ecron commented Jun 27, 2024

I just applied all your suggestions. I will join the Telegram channel, thanks!

@zamitto zamitto merged commit e4020d5 into hydralauncher:main Jun 27, 2024
3 checks passed
@zamitto
Copy link
Collaborator

zamitto commented Jun 27, 2024

Before merging I removed strings that are not used anymore.
If you use VS Code, i recommend using the i18n Ally extension, you can see the missing strings for each translation. Helps a lot.

@Ecron Ecron deleted the lang-ca branch June 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants