Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydro_deploy)!: make Host trait use &self interior mutability to remove RwLock wrappings #430 #1347

Merged
merged 1 commit into from
Jul 20, 2024
Merged

refactor(hydro_deploy)!: make Host trait use &self interior mutability to remove RwLock wrappings #430 #1347

merged 1 commit into from
Jul 20, 2024

Conversation

MingweiSamuel
Copy link
Member

Depends on #1346

@MingweiSamuel MingweiSamuel mentioned this pull request Jul 16, 2024
Merged
@MingweiSamuel MingweiSamuel changed the title refactor(hydro_deploy)!: make Host trait use shared & references/interior mutability to remove RwLock wrappings refactor(hydro_deploy)!: make Host trait use &self interior mutability to remove RwLock wrappings Jul 16, 2024
@MingweiSamuel MingweiSamuel marked this pull request as ready for review July 19, 2024 20:57
@MingweiSamuel MingweiSamuel changed the title refactor(hydro_deploy)!: make Host trait use &self interior mutability to remove RwLock wrappings refactor(hydro_deploy)!: make Host trait use &self interior mutability to remove RwLock wrappings #430 Jul 19, 2024
shadaj
shadaj requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

hydro_deploy/hydro_cli/src/lib.rs Show resolved Hide resolved
@MingweiSamuel
refactor(hydro_deploy)!: make Host trait use shared & references/…
1d5e02a 
…interior mutability to remove `RwLock` wrappings
@MingweiSamuel MingweiSamuel enabled auto-merge (squash) July 20, 2024 00:14
@MingweiSamuel MingweiSamuel merged commit c5a8de2 into hydro-project:main Jul 20, 2024
13 checks passed
@MingweiSamuel MingweiSamuel deleted the hd-no-mut-3 branch July 20, 2024 00:25
MingweiSamuel added a commit that referenced this pull request Jul 22, 2024
@MingweiSamuel
refactor(hydro_deploy)!: make Service::collect_resources take `&sel…
2286558 
…f` instead of `&mut self` (#1348)

#430 but still has `RwLock` wrapping

Depends on #1347
@MingweiSamuel MingweiSamuel mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MingweiSamuel @shadaj