Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further SampleEditor tweaks #1304

Open
5 tasks
theGreatWhiteShark opened this issue Jun 24, 2021 · 2 comments
Open
5 tasks

Further SampleEditor tweaks #1304

theGreatWhiteShark opened this issue Jun 24, 2021 · 2 comments

Comments

@theGreatWhiteShark
Copy link
Contributor

theGreatWhiteShark commented Jun 24, 2021

  • Open the SampleEditor -> enter a large value in the spinbox of the "Start" and press enter -> both the values in the spinboxes of "Start" and "Loop" get updated but only the "S" line gets moved in the wave display while "L" remains at zero.
  • Open the SampleEditor -> change something and hit the "Close" button -> a dialog "Unsave changes..." will pop up and the user has to consent to discard the changes -> clicking "Ok" and reopen the SampleEditor by clicking "Edit Layer" again -> the same popup shows up again. I think the second one is a dud.
  • When entering a fresh instance of the SampleEditor the value of the EndFrameSpinBox looks perfectly fine. But as soon as the mouse pointer enters the MainSampleWaveDisplay it is reset to 0 by SampleEditor::getAllFrameInfos() what causes some other oddities. The slider, however, stays at it's correct position. This also caused sample editor : end marker jumps to start marker position #811.
  • The first value change in the Start, Loop, and End spinboxes is discarded and, instead, the slider is shown in the DetailWaveDisplay. It would be nice to update the DetailWaveDisplay as soon as the spinboxes have focus and make the first change affect the value as well.
  • When both the volume and pan envelops are edited, it's not straight forward to see which one is selected by looking at the envelopes. If think it would improve usability to make the only currently not selected more transparent to indicate its state.
@theGreatWhiteShark theGreatWhiteShark added this to the 1.2 milestone Jun 24, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 5, 2021
@charbeljc
Copy link
Contributor

charbeljc commented Jul 6, 2021

* Open the `SampleEditor` -> enter a large value in the spinbox of the "Start" and press enter -> both the values in the spinboxes of "Start" and "Loop" get updated but only the "S" line gets moved in the wave display while "L" remains at zero.

Hum, I'm afraid this one was my fault ..

* Open the `SampleEditor` -> change something and hit the "Close" button -> a dialog "Unsave changes..." will pop up and the user has to consent to discard the changes -> clicking "Ok" and reopen the `SampleEditor` by clicking "Edit Layer" again -> the same popup shows up again. I think the second one is a dud.

Same here, the call to setClean() was misplaced in the SampleEditor's setup.

* When entering a fresh instance of the `SampleEditor` the value of the `EndFrameSpinBox` looks perfectly fine. But as soon as the mouse pointer enters the `MainSampleWaveDisplay` it is reset to 0 by `SampleEditor::getAllFrameInfos()` what causes some other oddities. The slider, however, stays at it's correct position. This also caused [sample editor : end marker jumps to start marker position #811](https://github.com/hydrogen-music/hydrogen/issues/811).

This is fixed with my PR.

* The first value change in the Start, Loop, and End spinboxes is discarded and, instead, the slider is shown in the `DetailWaveDisplay`. It would be nice to update the `DetailWaveDisplay` as soon as the spinboxes have focus and make the first change affect the value as well.

Also done in #1314,
Regards.

@theGreatWhiteShark
Copy link
Contributor Author

This is fixed with my PR.

Nice! I will have a look tomorrow.

charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 6, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 7, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 7, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 15, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 15, 2021
charbeljc added a commit to charbeljc/hydrogen that referenced this issue Jul 15, 2021
@theGreatWhiteShark theGreatWhiteShark removed this from the 1.2 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants