Playlist Tempo Bug #1779
Comments
tempo changes applied without an explicit user action, like loading a song, did trigger the `PlayerControl::bpmChanged()` slot of the bpm lcd widget as well. This led to spurious and random tempo changes when switching between different tempi in batch assignment in short time, e.g. switching from a song using 140bpm to one with 180bpm (and resetting the audio engine to default 120bpm inbetween). fixes hydrogen-music#1779
tempo changes applied without an explicit user action, like loading a song, did trigger the `PlayerControl::bpmChanged()` slot of the bpm lcd widget as well. This led to spurious and random tempo changes when switching between different tempi in batch assignment in short time, e.g. switching from a song using 140bpm to one with 180bpm (and resetting the audio engine to default 120bpm inbetween). fixes hydrogen-music#1779
|
The description of #1781 seems plausible as a cause of my issue. However, using my existing version 1.2.0 I tried moving through a playlist slowly (waiting several seconds between songs) and still had incorrect song tempos. If you're asking me to build Hydrogen from source, I'm not set up to do that. However, if you can upload a new binary somewhere I will test it. |
No, you would need the build the code to try the fixed version.
For Linux we do not provide binaries. Most libraries are dynamically linked and Linux distributions differ way too much to make the resulting binary portable. There may be a portable AppImage of the latest Hydrogen version in the future. But we are not there yet. Alright, then I'll close this issue as completed for now. In case you experience this problem in the upcoming 1.2.1 release, please reopen this ticket. |
Fix spurious tempo changes to 120 bpm (#1779)
tempo changes applied without an explicit user action, like loading a song, did trigger the `PlayerControl::bpmChanged()` slot of the bpm lcd widget as well. This led to spurious and random tempo changes when switching between different tempi in batch assignment in short time, e.g. switching from a song using 140bpm to one with 180bpm (and resetting the audio engine to default 120bpm inbetween). fixes #1779
|
I just installed 1.2.1 and the issue now appears to be fixed. Thanks. |
Hydrogen version * : 1.2.0
Operating system + version : Arch Linux (current)
Audio driver + version : JACK
When recalling a song from a playlist, the song's tempo is sometimes (randomly?) set to 120 BPM instead of the tempo listed in the song file. This problem started with version 1.2.0.
Steps to reproduce:
Create two or more song files with tempos other than 120 BPM. Create a playlist of these files.
With the playlist active, use the F6/F5 keys to move through the playlist. The tempo will sometimes get set to 120 BPM in error. Moving to a different song and back to problem song once or twice will usually correct the tempo.
The problem can also happen when opening a song file from the Playlist Editor but seems to be more common when using the F6/F5 keys.
The text was updated successfully, but these errors were encountered: