Issue with importing drumkit (2/2)

[trebmuh]

Following the first importing drumkit issue (#298 ), I'm reporting here that the drumkit "K-27 Trash Kit" is not downloadable at all. When trying to, the process is going very fast and there is no error message, but the drumkit is staying as "New" on the list, and nothing is written in ~/.hydrogen/data/drumkits/

[mauser]

Hi,

Thanks for reporting this case, it seems that the server which hosts the kit is down. I'll see if this is a temporary issue or if the domain has changed or sth...

[thijz]

related to #269 ?

[thijz]

i can confirm this : just retested with todays code > issue still present

[trebmuh]

 @mauser : a user can understand that a 3rd party furnished piece of code can fail because of an unreachable server. The frustration part is that I didn't have any pop up message about that so I was lucky that you answered my question here :) Would it then be possible to add such a pop up windows saying "sorry dude, the server which usually delivers "best-hydrogen-drumkit-ever" looks to be dead at the moment. Please retry later or contact the hydrogen-dev team (or whoever relevant)" ?
Cheers.

[mauser]

Yes, it would be helpful if there would be such a message.. i will see if the API that we're using returns meaningful error values. Btw, the error message from QT is directly printed at the hydrogen debug log (you can that in a terminal if you start hydrogen from a terminal).

[trebmuh]

Sweat. Let me know if you want some testing about this, I'd be more than happy to help this way since I'm not into coding.

[mauser]

Hi,

I rewrote the code now and introduced a new error handling. Please try again.. Btw, if not corrected the entry on the server yet, so that you could test the new error handling.. Will fix that if this is confirmed.

[trebmuh]

Sweat, the pop up message works fine as follow:

that said, after clicking OK, I'm still having this one popping up as well:

which is confusing for an user perspective: "has it been downloaded or not ?"

Would it be possible then to remove the 2nd message in this case scenario ?

[mauser]

Thanks for the hint, this is now also fixed.

[trebmuh]

Sweat, thanks for fixing this. I just tested it with the 0.9.7beta1 and it's all good now.
I'm closing this issue then.